Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestClosedPipeRaceWrite fails on solaris-amd64-smartosbuildlet #27566

Closed
tklauser opened this issue Sep 8, 2018 · 7 comments
Closed

os: TestClosedPipeRaceWrite fails on solaris-amd64-smartosbuildlet #27566

tklauser opened this issue Sep 8, 2018 · 7 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Solaris release-blocker
Milestone
Go1.12

Comments

@tklauser
Copy link
Member

tklauser commented Sep 8, 2018 

--- FAIL: TestClosedPipeRaceWrite (0.00s)
    pipe_test.go:140: using pipe write limit of 65537
    pipe_test.go:176: I/O on closed pipe unexpectedly succeeded
panic: Fail in goroutine after TestClosedPipeRaceWrite has completed

https://build.golang.org/log/ecf3e947caaa3976539a524f6b63f12fac0ea3a4

It used to pass occasionally in the past, but now it seems to fail on every build.

FWIW, PIPE_BUF is 512 on illumos/SmartOS: https://github.com/illumos/illumos-gate/blob/b075503f221374dd0495c40e8811d229cb9fdc74/usr/src/head/limits.h#L97

/cc @ianlancetaylor
@tklauser tklauser added OS-Solaris NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 8, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Sep 8, 2018
@ianlancetaylor
Copy link
Member

Does it fail in 1.11 or only on tip?

@tklauser
Copy link
Member Author

tklauser commented Sep 8, 2018

It also fails on 1.11

@tklauser tklauser mentioned this issue Sep 25, 2018
Closed
@bradfitz
Copy link
Contributor

I suspect there are just spinning processes in the background.

That builder isn't created & destroyed per build (in either a container or VM). It's just a process running in a loop.

/cc @dmitshur

@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Sep 25, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/138255 mentions this issue: env/solaris-amd64/joyent: add more ssh/key info

@bradfitz
Copy link
Contributor

I logged into our two Joyent SmartOS VMs and they seem fine. (nothing obviously spinning or disks full, etc)

gopherbot pushed a commit to golang/build that referenced this issue Oct 2, 2018
@bradfitz
env/solaris-amd64/joyent: add more ssh/key info
452a194 
Updates golang/go#27566

Change-Id: I5b306fb5832bdfad564c52df5b8ceb7ff7025bd0
Reviewed-on: https://go-review.googlesource.com/138255
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@tklauser
Copy link
Member Author

tklauser commented Dec 4, 2018

Seems to be fixed by https://golang.org/cl/152164 but the commit message did not reference this issue. Thus closing manually.

@tklauser tklauser closed this as completed Dec 4, 2018
@ianlancetaylor
Copy link
Member

Thanks. Sorry about that. I should have checked for an open issue.

@golang golang locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Solaris release-blocker
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@bradfitz @tklauser @ianlancetaylor @gopherbot