Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestClosedPipeRaceWrite fails on solaris-amd64-smartosbuildlet #27566

Closed
tklauser opened this issue Sep 8, 2018 · 7 comments
Closed

os: TestClosedPipeRaceWrite fails on solaris-amd64-smartosbuildlet #27566

tklauser opened this issue Sep 8, 2018 · 7 comments

Comments

@tklauser
Copy link
Member

@tklauser tklauser commented Sep 8, 2018

--- FAIL: TestClosedPipeRaceWrite (0.00s)
    pipe_test.go:140: using pipe write limit of 65537
    pipe_test.go:176: I/O on closed pipe unexpectedly succeeded
panic: Fail in goroutine after TestClosedPipeRaceWrite has completed

https://build.golang.org/log/ecf3e947caaa3976539a524f6b63f12fac0ea3a4

It used to pass occasionally in the past, but now it seems to fail on every build.

FWIW, PIPE_BUF is 512 on illumos/SmartOS: https://github.com/illumos/illumos-gate/blob/b075503f221374dd0495c40e8811d229cb9fdc74/usr/src/head/limits.h#L97

/cc @ianlancetaylor

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Sep 8, 2018

Does it fail in 1.11 or only on tip?

@tklauser

This comment has been minimized.

Copy link
Member Author

@tklauser tklauser commented Sep 8, 2018

It also fails on 1.11

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Sep 25, 2018

I suspect there are just spinning processes in the background.

That builder isn't created & destroyed per build (in either a container or VM). It's just a process running in a loop.

/cc @dmitshur

@bradfitz bradfitz added the Builders label Sep 25, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 27, 2018

Change https://golang.org/cl/138255 mentions this issue: env/solaris-amd64/joyent: add more ssh/key info

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Sep 27, 2018

I logged into our two Joyent SmartOS VMs and they seem fine. (nothing obviously spinning or disks full, etc)

gopherbot pushed a commit to golang/build that referenced this issue Oct 2, 2018
Updates golang/go#27566

Change-Id: I5b306fb5832bdfad564c52df5b8ceb7ff7025bd0
Reviewed-on: https://go-review.googlesource.com/138255
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@tklauser

This comment has been minimized.

Copy link
Member Author

@tklauser tklauser commented Dec 4, 2018

Seems to be fixed by https://golang.org/cl/152164 but the commit message did not reference this issue. Thus closing manually.

@tklauser tklauser closed this Dec 4, 2018
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 5, 2018

Thanks. Sorry about that. I should have checked for an open issue.

@golang golang locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.