Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
crypto/x509: Insufficient verification of ServerName when certificate is wildcard #27591
What version of Go are you using (
Hmm, yeah that should not succeed, but we can't just apply verifyHostname, as there are a bunch of non-PKI users that put all sorts of things in the SAN (like the CloudSQL
However, we can probably make it a requirement for wildcard matching, as wildcards are only meaningfully defined over hostnames.
oh i didn't know that. thx you for teaching me.
I tried to verify the hostname only when wildcards are used.