Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/crypto: add support for AES Key Wrap #27599

Open
bdhess opened this issue Sep 10, 2018 · 3 comments

Comments

@bdhess
Copy link

commented Sep 10, 2018

AES Key Wrap is defined in RFC 3394 (plain) and RFC 5649 (with padding).

The implementation is straightforward and the relevant RFCs come with test vectors. I have an implementation complete that I'd be happy to submit. I'd suggest adding it to a package named x/crypto/aeswrap to avoid confusion with the AES data encryption functionality in crypto/aes.

@jefferai

This comment has been minimized.

Copy link

commented Jun 10, 2019

@bdhess Any chance you've open-sourced your implementation in the mean time?

@bdhess

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

We released the variant with padding in google/tink@22467ef

Note that the Tink implementation is fairly opinionated: no 192-bit wrapping keys, and wrapped keys must be between 16 and 8192 bytes inclusive.

@jefferai

This comment has been minimized.

Copy link

commented Jun 10, 2019

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.