Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: drop support for FreeBSD 10 #27619

Open
tklauser opened this Issue Sep 11, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@tklauser
Copy link
Member

tklauser commented Sep 11, 2018

This came up during the review of https://golang.org/cl/114826. Deprecation of support for FreeBSD 10 was supposed to be announced in the Go 1.10 release notes according to #22911 (comment)

So I guess this means we should announce deprecation of FreeBSD 10 support in Go 1.12 and drop it in Go 1.13

/cc @bradfitz @paulzhol

@tklauser tklauser added the OS-FreeBSD label Sep 11, 2018

@tklauser tklauser added this to the Go1.12 milestone Sep 11, 2018

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 18, 2018

Change https://golang.org/cl/150159 mentions this issue: doc/go1.12: announce deprecation of support for FreeBSD 10.x

@gopherbot gopherbot closed this in 0f02664 Nov 20, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Nov 20, 2018

This bug was titled "drop support for FreeBSD 10" but it was marked fixed by a CL that just documented that we plan to do this.

I'm going to reopen this and assign to Go 1.13.

@bradfitz bradfitz modified the milestones: Go1.12, Go1.13 Nov 20, 2018

@bradfitz bradfitz reopened this Nov 20, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Nov 20, 2018

/cc @mikioh

@tklauser

This comment has been minimized.

Copy link
Member Author

tklauser commented Nov 21, 2018

This was closed again due to the git history rewrite (https://groups.google.com/forum/#!topic/golang-dev/8JmYrD3DWY0). Reopening.

@tklauser tklauser reopened this Nov 21, 2018

gopherbot pushed a commit that referenced this issue Jan 9, 2019

os: always treat files as unpollable on FreeBSD
Fixes #29633
Updates #27619

Change-Id: I1e38569ea2a02423b028331f2ed987d3ae47fd2e
Reviewed-on: https://go-review.googlesource.com/c/157099
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 9, 2019

Change https://golang.org/cl/157099 mentions this issue: os: always treat files as unpollable on FreeBSD

zchee pushed a commit to zchee/golang-wiki that referenced this issue Jan 28, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 1, 2019

Change https://golang.org/cl/160777 mentions this issue: cmd/cgo: ignore unrecognized GCC warning group pragmas

gopherbot pushed a commit that referenced this issue Feb 1, 2019

cmd/cgo: ignore unrecognized GCC warning group pragmas
CL 159859 causes build failure with old clang versions (3.4.1) on FreeBSD 10.3/10.4.

Update #29962
Update #27619

Change-Id: I78264ac5d8d17eeae89a982e89aac988eb22b286
Reviewed-on: https://go-review.googlesource.com/c/160777
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

nebulabox added a commit to nebulabox/go that referenced this issue Feb 18, 2019

cmd/cgo: ignore unrecognized GCC warning group pragmas
CL 159859 causes build failure with old clang versions (3.4.1) on FreeBSD 10.3/10.4.

Update golang#29962
Update golang#27619

Change-Id: I78264ac5d8d17eeae89a982e89aac988eb22b286
Reviewed-on: https://go-review.googlesource.com/c/160777
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

nebulabox added a commit to nebulabox/go that referenced this issue Feb 20, 2019

cmd/cgo: ignore unrecognized GCC warning group pragmas
CL 159859 causes build failure with old clang versions (3.4.1) on FreeBSD 10.3/10.4.

Update golang#29962
Update golang#27619

Change-Id: I78264ac5d8d17eeae89a982e89aac988eb22b286
Reviewed-on: https://go-review.googlesource.com/c/160777
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 6, 2019

Change https://golang.org/cl/165799 mentions this issue: runtime: remove CPU capability workarounds for unsupported FreeBSD versions

gopherbot pushed a commit that referenced this issue Mar 7, 2019

runtime: remove CPU capability workarounds for unsupported FreeBSD ve…
…rsions

This CL removes runtime code working around missing ARM processor capability
information in the auxiliary vector in older FreeBSD versions.

As announced in the Go 1.12 release notes Go 1.13 will require FreeBSD 11.2+
or FreeBSD 12.0+. These FreeBSD versions support CPU capability detection
through AT_HWCAP and AT_HWCAP2 values stored in the auxiliary vector.

Updates #27619

Change-Id: I2a457b578d35101a7a5fd56ae9b81b300ad17da4
Reviewed-on: https://go-review.googlesource.com/c/go/+/165799
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Martin Möhrmann <martisch@uos.de>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 7, 2019

Change https://golang.org/cl/165800 mentions this issue: cmd/cgo: adjust comment about ignored pragma warnings

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 7, 2019

Change https://golang.org/cl/165801 mentions this issue: os: drop special case for FreeBSD 10.4 in newFile

gopherbot pushed a commit that referenced this issue Mar 8, 2019

cmd/cgo: adjust comment about ignored pragma warnings
The warnings are not strictly tied to FreeBSD but to the clang version.
People could still be building with an old version of clang even if not
on FreeBSD. The -Wpragmas and -Waddress-of-packed-member warnings were
introduced in clang 4.0, so also adjust the comment accordingly.

This was discussed as part of CL 160777 which introduced these comments.

Updates #27619

Change-Id: I4988ffd08797dcc72cdc264d4abd20a114f70473
Reviewed-on: https://go-review.googlesource.com/c/go/+/165800
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

gopherbot pushed a commit that referenced this issue Mar 12, 2019

os: drop special case for FreeBSD 10.4 in newFile
Support for FreeBSD 10 will be dropped with Go 1.13, so revert the
workaround introduced in CL 157099.

Updates #29633
Updates #27619

Change-Id: I1a2e50d3f807a411389f3db07c0f4535a590da02
Reviewed-on: https://go-review.googlesource.com/c/go/+/165801
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.