Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestSpuriousWakeupsNeverHangSemasleep doesn't build on Plan 9 #27662

Closed
0intro opened this issue Sep 13, 2018 · 4 comments
Closed

runtime: TestSpuriousWakeupsNeverHangSemasleep doesn't build on Plan 9 #27662

0intro opened this issue Sep 13, 2018 · 4 comments
Assignees
Milestone

Comments

@0intro
Copy link
Member

@0intro 0intro commented Sep 13, 2018

CL 135015 added TestSpuriousWakeupsNeverHangSemasleep. This test is failing on Plan 9 because syscall.SIGIO is not defined.

# runtime_test [runtime.test]
go/src/runtime/semasleep_test.go:74:23: undefined: syscall.SIGIO
FAIL	runtime [build failed]

See https://build.golang.org/log/a16a3aa8831cb7b424c37ccb0ce84a88ca27b5dc

@0intro 0intro added the OS-Plan9 label Sep 13, 2018
@0intro 0intro added this to the Go1.12 milestone Sep 13, 2018
@0intro 0intro self-assigned this Sep 13, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 13, 2018

Change https://golang.org/cl/135315 mentions this issue: runtime: don't build semasleep_test on Plan 9

@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Sep 13, 2018

Thanks for catching that @0intro! Interestingly though yesterday it built successfully https://go-review.googlesource.com/c/go/+/135015#message-01bdd240e139e50a967331d9c6095945f2ce702f

@0intro

This comment has been minimized.

Copy link
Member Author

@0intro 0intro commented Sep 13, 2018

Unfortunately, the plan9 trybot has been disabled a while ago. The misc-compile-plan9 trybot only builds Go, without running the tests. However, the tests are only built when executed.
That's why this oversight hasn't been catched by the trybot.

@gopherbot gopherbot closed this in 7c95703 Sep 13, 2018
@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Sep 13, 2018

Gotcha, thanks for the fix @0intro!

@golang golang locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.