New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: limit the number of auto-assigned reviewers #27683

Open
josharian opened this Issue Sep 14, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@josharian
Contributor

josharian commented Sep 14, 2018

This is a follow-up issue to the discussion at https://groups.google.com/forum/#!topic/golang-dev/CdGrNJDcqec, to make sure it doesn't get lost.

In that thread @mvdan proposed:

If a CL were to ping more than 5 people, simply fallback to pinging someone on the core team (Andy? Ian? Brad?), who can then make a better call than a machine could

I think we should do this.

@dmitshur @andybons

@gopherbot gopherbot added this to the Unreleased milestone Sep 14, 2018

@gopherbot gopherbot added the Builders label Sep 14, 2018

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Sep 14, 2018

Member

I'll wait to hear @andybons thoughts on this, but I'd say if we're going to treat "would ping more than 5 people" specially, it should just avoid doing anything.

I don't think it's viable to pick only a single person on the core team to always get pinged, and it may not be a trivial effort to add a rotation going just for these kinds of CLs. The safest thing is for gopherbot to say "welp, this is too hard for me to deal with, I'll tag it as no-owners and back out". Then humans can pick it up, just like all previous CLs before gopherbot did the reviewer assignments.

About 'no-owners' Tag

The no-owners is applied by gopherbot when it can't find an owner for the affected code. See CL
121018
description:

If no owners can be found, the tag 'no-owners' is added to the
change to prevent gopherbot from making unneeded API calls.

Member

dmitshur commented Sep 14, 2018

I'll wait to hear @andybons thoughts on this, but I'd say if we're going to treat "would ping more than 5 people" specially, it should just avoid doing anything.

I don't think it's viable to pick only a single person on the core team to always get pinged, and it may not be a trivial effort to add a rotation going just for these kinds of CLs. The safest thing is for gopherbot to say "welp, this is too hard for me to deal with, I'll tag it as no-owners and back out". Then humans can pick it up, just like all previous CLs before gopherbot did the reviewer assignments.

About 'no-owners' Tag

The no-owners is applied by gopherbot when it can't find an owner for the affected code. See CL
121018
description:

If no owners can be found, the tag 'no-owners' is added to the
change to prevent gopherbot from making unneeded API calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment