Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: build.golang.org dashboard with “show only first-class ports” checked displays more than just first-class ports #27689

Open
bcmills opened this issue Sep 14, 2018 · 7 comments
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Sep 14, 2018

When I check “show only first-class ports” on https://build.golang.org/#short, the list of matching builders is still quite long:

screenshot 2018-09-14 at 14 51 23


I had assumed that it would be restricted to the list of ports on https://golang.org/wiki/PortingPolicy#first-class-ports, but in fact that list is much, much shorter:

screenshot 2018-09-14 at 14 51 46


To avoid confusion, they should be made consistent: if the ports in the builder really are first-class, they should be listed on (or linked from) the wiki page, and if they aren't, they should be filtered out of the dashboard view.

(Discovered via #27686 (comment).)

@gopherbot gopherbot added this to the Unreleased milestone Sep 14, 2018
@gopherbot gopherbot added the Builders label Sep 14, 2018
@bcmills
Copy link
Member Author

@bcmills bcmills commented Sep 14, 2018

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 15, 2018

I can fix the discrepancy, but I'll need the decision of which are to be considered first-class vs not.

Here's the current first-class port list from build.golang.org in text form:

darwin/386:

  • darwin-386-10_11

darwin/amd64:

  • darwin-amd64-10_10
  • darwin-amd64-10_11
  • darwin-amd64-10_12

darwin/arm:

  • darwin-arm-mg912baios

darwin/arm64:

  • darwin-arm64-mn4m2zdaios

freebsd/386:

  • freebsd-386-10_3
  • freebsd-386-11_1

freebsd/amd64:

  • freebsd-amd64-10_3
  • freebsd-amd64-11_1

freebsd/arm:

  • freebsd-arm-paulzhol

linux/386:

  • linux-386
  • linux-386-387
  • linux-386-clang
  • linux-386-sid

linux/amd64:

  • linux-amd64
  • linux-amd64-clang
  • linux-amd64-longtest
  • linux-amd64-nocgo
  • linux-amd64-noopt
  • linux-amd64-racecompile
  • linux-amd64-sid
  • linux-amd64-ssacheck
  • linux-amd64-stretch

linux/arm:

  • linux-arm
  • linux-arm-arm5spacemonkey
  • linux-arm-nativemake

linux/arm64:

  • linux-arm64-packet

linux/mips:

  • linux-mips

linux/mipsle:

  • linux-mipsle

linux/ppc64:

  • linux-ppc64-buildlet

linux/ppc64le:

  • linux-ppc64le-buildlet

linux/s390x:

  • linux-s390x-ibm

windows/386:

  • windows-386-2008

windows/amd64:

  • windows-amd64-2008
  • windows-amd64-2012
  • windows-amd64-2016

windows/arm:

  • windows-arm

race:

  • darwin-amd64-race
  • freebsd-amd64-race
  • linux-amd64-race
  • windows-amd64-race
  • android-386-emulator
  • android-amd64-emulator
  • android-arm-wiko-fever
  • android-arm64-wiko-fever
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 14, 2018

Change https://golang.org/cl/149606 mentions this issue: dashboard: add FirstClass field to BuildConfig

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 26, 2019

Change https://golang.org/cl/202197 mentions this issue: doc: update ports list description to reflect current status

gopherbot pushed a commit that referenced this issue Nov 2, 2019
This change updates the GOARCH/GOOS discussion at the top of the
"Installing Go from source" document to better reflect the current
status. In particular:

- The GOARCH list now focuses on simply listing the supported
architectures, with no notes about their supposed "maturity", since
the same GOARCH can be mature on a GOOS and not so mature on another.

- Outdated notes about some archs being new and "not well-exercised"
have been removed in favour of a following list of which ports are
first class.

- The list of supported OS has been updated (added: AIX, Illumos),
and sorted in alphabetical order.

- A note about the runtime support being the same for all ARCHS,
"including garbage collection and efficient array slicing and" etc etc
has been removed, since it doesn't seem particularly relevant in a
"install from source" instruction page, and it's likely a leftover
from the time this doc page was the landing place for new people and
it felt the need to "sell" Go.

Updates #27689
Fixes #35009

Change-Id: Ic4eca91dca3135adc7bed4fe00b4f157768f0e81
Reviewed-on: https://go-review.googlesource.com/c/go/+/202197
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 7, 2020

/cc @toothrot In #38874 (comment), you said:

Somewhat related, as part of work to move the build dashboard into the coordinator (#34744), and have the "first-class ports" checkbox do the right thing on the UI, I hard-coded this field:
https://go.googlesource.com/build/+/refs/heads/master/cmd/coordinator/internal/dashboard/handler.go#29.

Based on that analysis, I understand that the "show only first-class ports" displaying more ports than are listed at https://golang.org/wiki/PortingPolicy#first-class-ports is simply a UI bug. If that's right, I understand we should be able to move this issue into NeedsFix state with the goal of fixing the UI bug on build.golang.org. Do you agree? Or do you think there is more that needs to be decided here?

@toothrot
Copy link
Contributor

@toothrot toothrot commented May 7, 2020

@dmitshur That is being fixed as part of #34744 (and is in-fact already fixed in the new UI, that is not yet feature complete)

@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 7, 2020

Great! I'll update this issue to reflect the latest state.

@dmitshur dmitshur changed the title x/build: dashboard “first-class ports” view doesn't match wiki x/build: build.golang.org dashboard with “show only first-class ports” checked displays more than just first-class ports May 7, 2020
@dmitshur dmitshur added NeedsFix and removed NeedsDecision labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.