cmd/go/internal/modfetch: TestCodeRepoVersions is failing on longtest

[dmitshur]

It started to fail since https://build.golang.org/log/40438df21477eaace5ea36bb0010be8bcfc2bc58 and has been failing on linux-amd64-longtest since. That commit was not related, so I'm guessing the problem is on the internet side.

go: finding github.com/rsc/vgotest1 v0.0.0
go: finding vcs-test.golang.org/hg/vgotest1.hg v0.0.0
go: finding github.com/rsc/vgotest1 v1.0.0
go: finding vcs-test.golang.org/hg/vgotest1.hg v1.0.0
go: finding github.com/rsc/vgotest1/v2 v2.0.0
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 v2.0.0
go: finding github.com/rsc/vgotest1 80d85c5
go: finding vcs-test.golang.org/hg/vgotest1.hg e125018
go: finding github.com/rsc/vgotest1 mytag
go: finding vcs-test.golang.org/hg/vgotest1.hg mytag
go: finding github.com/rsc/vgotest1/v2 45f53230a
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 814fce58e
go: finding github.com/rsc/vgotest1/v54321 80d85c5
go: finding vcs-test.golang.org/hg/vgotest1.hg/v54321 e125018
go: finding github.com/rsc/vgotest1/submod v1.0.0
go: finding vcs-test.golang.org/hg/vgotest1.hg/submod v1.0.0
go: finding github.com/rsc/vgotest1/submod v1.0.3
go: finding vcs-test.golang.org/hg/vgotest1.hg/submod v1.0.3
go: finding github.com/rsc/vgotest1/submod v1.0.4
go: finding vcs-test.golang.org/hg/vgotest1.hg/submod v1.0.4
go: finding github.com/rsc/vgotest1 v1.1.0
go: finding vcs-test.golang.org/hg/vgotest1.hg v1.1.0
go: finding github.com/rsc/vgotest1/v2 v2.0.1
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 v2.0.1
go: finding github.com/rsc/vgotest1/v2 v2.0.3
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 v2.0.3
go: finding github.com/rsc/vgotest1/v2 v2.0.4
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 v2.0.4
go: finding github.com/rsc/vgotest1/v2 v2.0.5
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 v2.0.5
go: finding rsc.io/quote v1.0.0
go: finding swtch.com/testmod v1.0.0
go: finding golang.org/x/text 4e4a3210bb
go: finding github.com/pkg/errors v0.8.0
go: finding github.com/rsc/quote/buggy c4d4236f
go: finding gopkg.in/yaml.v2 d670f940
go: finding gopkg.in/check.v1 20d25e280405
go: finding gopkg.in/yaml.v2 v2
go: finding vcs-test.golang.org/go/mod/gitrepo1 master
go: finding gopkg.in/natefinch/lumberjack.v2 latest
go: finding gopkg.in/natefinch/lumberjack.v2 v2.1
--- FAIL: TestCodeRepoVersions (1.15s)
    --- FAIL: TestCodeRepoVersions/gopkg.in_natefinch_lumberjack.v2 (0.00s)
        coderepo_test.go:535: Versions(""):
            have [v2.0.0]
            want []
go: finding github.com/rsc/empty latest
go: finding github.com/rsc/vgotest1 latest
go: finding github.com/rsc/vgotest1/subdir latest
go: finding swtch.com/testmod latest
FAIL
FAIL	cmd/go/internal/modfetch	31.494s

I can reproduce locally:

$ go version
go version devel +58c6afe075 Fri Sep 14 21:45:02 2018 +0000 darwin/amd64
$ go test -run=TestCodeRepoVersions cmd/go/internal/modfetch
--- FAIL: TestCodeRepoVersions (1.56s)
    --- FAIL: TestCodeRepoVersions/gopkg.in_natefinch_lumberjack.v2 (0.30s)
        coderepo_test.go:535: Versions(""):
            have [v2.0.0]
            want []
FAIL
FAIL	cmd/go/internal/modfetch	1.609s

/cc @rsc @bcmills @ianlancetaylor per owners, and @natefinch since it looks like your package is involved.

[natefinch]

I pushed a v2.0.0 tag to lumberjack very recently, to help module code figure out what to get... maybe I screwed up the tag?

[dmitshur]

From a glance, it looks like the test expects the tag not to be there.

[natefinch]

Umm.....

[dmitshur]

It's not very urgent to fix this, I just filed the issue so we don't forget.

The test was added 3 months ago in CL 118095 by @rsc. I'd wait for his comments on how to best resolve this.

It might be just a matter of updating the testdata to expect a v2.0.0 tag:

go/src/cmd/go/internal/modfetch/coderepo_test.go

Lines 510 to 513 in 58c6afe

	{
	path: "gopkg.in/natefinch/lumberjack.v2",
	versions: nil,
	},

It might also be worth rethinking whether the test should depend on your repo tags not changing.

[bcmills]

Yeah, we need to move the test over to some stable repo on vcs-test, or maybe just remove that case

[gopherbot]

Change https://golang.org/cl/136136 mentions this issue: cmd/go/internal/modfetch: remove test assumptions about external repo tags

[gopherbot]

Change https://golang.org/cl/137775 mentions this issue: cmd/go/internal/modfetch: update expected tags for external repos