Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: internal/ssa test TestNexting FAIL #27863

Closed
ALTree opened this issue Sep 25, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@ALTree
Copy link
Member

commented Sep 25, 2018

$ gotip version
go version devel +b3369063e5 Mon Sep 24 20:56:48 2018 +0000 linux/amd64

To reproduce:

$ cd src/cmd/compile/internal/ssa

$ gotip test -run=TestNexting 
--- FAIL: TestNexting (11.45s)
    --- FAIL: TestNexting/gdb-opt-hist (2.60s)
        debug_test.go:241: step/next histories differ, diff=
            --- testdata/hist.gdb-opt.nexts	2018-08-22 12:53:28.852375848 +0200
            +++ /tmp/debug_test607949139/test-hist.gdb-opt.nexts	2018-09-25 22:05:45.646897247 +0200
            @@ -19,7 +19,7 @@
             65:		if len(os.Args) > 1 {
             73:		scanner := bufio.NewScanner(reader)
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -29,7 +29,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -39,7 +39,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -49,7 +49,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -59,7 +59,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -69,7 +69,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -79,7 +79,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -89,7 +89,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -99,7 +99,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             75:			s := scanner.Text()
             76:			i, err := strconv.ParseInt(s, 10, 64)
             77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
            @@ -109,7 +109,7 @@
             81:			hist = ensure(int(i), hist)
             82:			hist[int(i)]++
             74:		for scanner.Scan() { //gdb-opt=(scanner/A)
            -scanner = (struct bufio.Scanner *) <A>
            +scanner = (bufio.Scanner *) <A>
             86:		for i, a := range hist {
             87:			if a == 0 { //gdb-opt=(a,n,t)
             a = 0
FAIL
exit status 1
FAIL	cmd/compile/internal/ssa	11.454s

Spotted on the longtest builder (the test is not run in -short mode), which is currently broken by this failure: https://build.golang.org/log/8c82dba33fed13b803174a6fb2b5aa675192623f

The first bad commit appears to be at https://go-review.googlesource.com/c/go/+/134555

cc @aarzilli @thanm

@ALTree ALTree added this to the Go1.12 milestone Sep 25, 2018

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2018

Should be just a matter of updating the expected output... I'll send a CL.

@thanm

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

Thanks @ALTree -- I agree that it's just a question of remastering the expected output.

@gopherbot

This comment has been minimized.

Copy link

commented Sep 25, 2018

Change https://golang.org/cl/137455 mentions this issue: cmd/compile: update TestNexting golden file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.