New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect: MethodByName().Interface() leads to fatal error: sweep increased allocation count [1.10 backport] #27866

Open
gopherbot opened this Issue Sep 25, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@gopherbot

gopherbot commented Sep 25, 2018

@randall77 requested issue #27695 to be considered for backport to the next 1.10 minor release.

@gopherbot, please open a backport issue please.

This has been broken for a while, but it's a nasty bug. We should consider backporting it.

@gopherbot

This comment has been minimized.

gopherbot commented Sep 30, 2018

Change https://golang.org/cl/138586 mentions this issue: [release-branch.go1.10] reflect: fix s390x reflect method calls

@gopherbot

This comment has been minimized.

gopherbot commented Sep 30, 2018

Change https://golang.org/cl/138585 mentions this issue: [release-branch.go1.10] reflect: ensure correct scanning of return values

@gopherbot

This comment has been minimized.

gopherbot commented Sep 30, 2018

Change https://golang.org/cl/138584 mentions this issue: [release-branch.go1.10] reflect: use correct write barrier operations for method funcs

@gopherbot

This comment has been minimized.

gopherbot commented Oct 1, 2018

Change https://golang.org/cl/138587 mentions this issue: [release-branch.go1.10] runtime: don't dereference 0-length bitvectors

@dmitshur

This comment has been minimized.

Member

dmitshur commented Nov 1, 2018

@randall77 This patch does not apply cleanly to release-branch.go1.10 right now. If you still think this should be backported, can you please make a cherry-pick CL as described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls?

We can also decide this doesn't meet the backport policy criteria, since there is a workaround (update to Go 1.11.1, where this issue is resolved).

Edit: I'll move the milestone to Go 1.10.6 since it's too late for Go 1.10.5 release that's happening today.

@dmitshur dmitshur modified the milestones: Go1.10.5, Go1.10.6 Nov 1, 2018

@gopherbot

This comment has been minimized.

gopherbot commented Nov 2, 2018

Change https://golang.org/cl/147237 mentions this issue: [release-branch.go1.10] reflect: ensure correct scanning of return values

@bcmills

This comment has been minimized.

Member

bcmills commented Nov 19, 2018

@randall77, given the fix in 1.11 and the proximity to 1.12, is this still worth backporting to 1.10?

@dmitshur dmitshur modified the milestones: Go1.10.6, Go1.10.7 Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment