New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/analysis/analysistest: TestTheTest fails on Darwin and Windows #27877

Closed
andybons opened this Issue Sep 26, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@andybons
Member

andybons commented Sep 26, 2018

See https://build.golang.org/?repo=golang.org%2fx%2ftools

$ go test ./go/analysis/...
?   	golang.org/x/tools/go/analysis	[no test files]
--- FAIL: TestTheTest (0.11s)
    analysistest_test.go:44: got:
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:8:10: in 'want' comment: invalid syntax
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:5:9: diagnostic "call of println(...)" does not match pattern "wrong expectation text"
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:6:9: unexpected diagnostic: call of println(...)
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:7: expected diagnostic matching "unsatisfied expectation"
        want:
        a/b.go:8:10: in 'want' comment: invalid syntax
        a/b.go:5:9: diagnostic "call of println(...)" does not match pattern "wrong expectation text"
        a/b.go:6:9: unexpected diagnostic: call of println(...)
        a/b.go:7: expected diagnostic matching "unsatisfied expectation"
FAIL
FAIL	golang.org/x/tools/go/analysis/analysistest	0.119s

@andybons andybons added this to the Go1.11.1 milestone Sep 26, 2018

@andybons andybons changed the title from x/tools/go/analysis/analysistest: TestTheTest fails on Darwin to x/tools/go/analysis/analysistest: TestTheTest fails on Darwin and Windows Sep 26, 2018

@andybons andybons added the OS-Windows label Sep 26, 2018

@andybons andybons modified the milestones: Go1.11.1, Go1.12 Sep 26, 2018

@gopherbot

This comment has been minimized.

gopherbot commented Sep 26, 2018

Change https://golang.org/cl/137735 mentions this issue: go/analysis/analysistest/analysistest: fix test on non-Linux

@andybons

This comment has been minimized.

Member

andybons commented Sep 27, 2018

Still fails on Windows.

@andybons

This comment has been minimized.

Member

andybons commented Sep 27, 2018

Hm. Odd. The windows builders seem fine. Leaving to Alan to close if actually still failing on Win.

@dmitshur

This comment has been minimized.

Member

dmitshur commented Nov 1, 2018

The windows builders seem fine. Leaving to Alan to close if actually still failing on Win.

I'll close because this seems solved (and has the Soon label). Only s390x has failures, and they're in a different package. Alan, please re-open otherwise.

@dmitshur dmitshur closed this Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment