Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/internal/gccgoimporter: not all code ported to x/tools? #27891

Closed
griesemer opened this issue Sep 27, 2018 · 2 comments
Closed

go/internal/gccgoimporter: not all code ported to x/tools? #27891

griesemer opened this issue Sep 27, 2018 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Sep 27, 2018

Reminder issue. It appears that the x/tools version of gccgoimporter doesn't closely follow the std library in all cases (but for version adaptations).

Specifically, it appears that https://golang.org/cl/119895 is missing.

@griesemer griesemer self-assigned this Sep 27, 2018
@gopherbot gopherbot added this to the Gccgo milestone Sep 27, 2018
@griesemer griesemer added the NeedsInvestigation label Sep 27, 2018
@griesemer griesemer removed this from the Gccgo milestone Sep 27, 2018
@griesemer griesemer added this to the Go1.12 milestone Sep 27, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 17, 2018

Change https://golang.org/cl/142893 mentions this issue: go/internak/gccgoimporter: update package to match std lib version

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 17, 2018

Change https://golang.org/cl/142894 mentions this issue: go/internal/gccgoimporter: backport from x/tools to ensure identical code

gopherbot pushed a commit that referenced this issue Oct 17, 2018
…code

This change backports a minor modification of the x/tools version of this
code back into the std library. It simply ensures that both versions of
the code are the same and will simplify keeping them in sync down the
road.

While this is an API change, this is an internal package, so we're ok.

Updates #27891.

Change-Id: Ib153141382f727a2692ca80179ae09c4a383ba4f
Reviewed-on: https://go-review.googlesource.com/c/142894
Reviewed-by: Alan Donovan <adonovan@google.com>
@golang golang locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

2 participants