Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: clean up MarshalJSON + support xml #2793

Closed
rsc opened this issue Jan 26, 2012 · 3 comments
Closed

time: clean up MarshalJSON + support xml #2793

rsc opened this issue Jan 26, 2012 · 3 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Jan 26, 2012

1. Format should produce years that are at least 4 digits.
2. The year-padding code in MarshalJSON should go away.
3. The bulk of the MarshalJSON function (all except the "s)
    should be pulled into t.RFC3339().
4. MarshalJSON just calls RFC3339 and then adds quotes.
5. package xml should recognize time.Time and call RFC3339
   to get a representation/call time.Parse(time.RFC3339) to
   parse a representation.
@rsc
Copy link
Contributor Author

@rsc rsc commented Jan 30, 2012

Comment 1:

Labels changed: added go1-must.

@rsc
Copy link
Contributor Author

@rsc rsc commented Feb 7, 2012

Comment 2:

Owner changed to @rsc.

Status changed to Started.

@rsc
Copy link
Contributor Author

@rsc rsc commented Feb 8, 2012

Comment 3:

This issue was closed by revision 1d8250c.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 8, 2012
@rsc rsc self-assigned this Feb 8, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed priority-go1 labels Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.