Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/godoc/vfs/zipfs: remove zipfs package #27959

Open
broady opened this issue Oct 2, 2018 · 2 comments
Open

x/tools/godoc/vfs/zipfs: remove zipfs package #27959

broady opened this issue Oct 2, 2018 · 2 comments

Comments

@broady
Copy link
Member

@broady broady commented Oct 2, 2018

Once golang.org/cl/133355 is in, and #27205 is resolved, I don't think we need the zipfs package for godoc anymore.

As far as I know, it was created as a workaround for Google App Engine restrictions on number of files allowed in an app deployment.

@dmitshur dmitshur changed the title tools/godoc/vfs/zipfs: remove zipfs package x/tools/godoc/vfs/zipfs: remove zipfs package Oct 2, 2018
@gopherbot gopherbot added this to the Unreleased milestone Oct 2, 2018
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 2, 2018

Such a change would affect its users.

Do we have a policy to follow to removing non-internal subrepo packages? How do we decide when to do it? How to do it (perhaps deprecate first, remove after some pre-determined time; or something else)?

Loading

@SamWhited
Copy link
Member

@SamWhited SamWhited commented Oct 2, 2018

Can we move this to the subrepos? I use this package heavily in several products.

EDIT: higher-up in the subrepos, outside of the godoc tree, that is.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants