Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: flaky test failing in darwin-amd64-10_10 #27992

Open
katiehockman opened this Issue Oct 3, 2018 · 8 comments

Comments

Assignees
No one assigned
Labels
OS-Darwin Testing
Projects
None yet
Milestone
  Go1.13
5 participants
@katiehockman @ianlancetaylor @mikioh @andybons @gopherbot
@katiehockman
Copy link
Contributor

katiehockman commented Oct 3, 2018

We are getting flaky test failures in net. This has been somewhat rare in the past few months, but it has failed the last 5 builds, so probably worth looking into now.

--- FAIL: TestLookupDotsWithRemoteSource (15.57s)
    lookup_test.go:694: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 8.8.8.8:53: read udp 10.50.0.170:50511->8.8.8.8:53: i/o timeout (mode=go)
FAIL
FAIL	net	30.123s

Looks very related to #16865 closed 2 years ago.

@katiehockman katiehockman added OS-Darwin Testing labels Oct 3, 2018

@katiehockman

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

katiehockman commented Oct 3, 2018

/cc @mikioh @brad-burch @ianlancetaylor
@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

ianlancetaylor commented Oct 3, 2018

2018-06-13T18:06:14-537fb06/darwin-amd64-10_10
2018-06-13T18:06:14-537fb06/darwin-amd64-10_11
2018-06-26T16:40:09-8997ec1/darwin-amd64-10_10
2018-06-26T16:40:09-8997ec1/darwin-amd64-10_11
2018-06-26T16:40:09-8997ec1/darwin-amd64-race
2018-07-03T16:14:43-2ee6bfb/darwin-amd64-10_10
2018-07-03T16:14:43-2ee6bfb/darwin-amd64-10_12
2018-07-03T16:27:51-aad71d3/darwin-amd64-10_12
2018-07-03T17:37:40-5d4f047/darwin-386-10_11
2018-07-03T17:37:40-5d4f047/darwin-amd64-10_10
2018-07-03T17:37:40-5d4f047/darwin-amd64-10_11
2018-07-09T22:19:21-94076fe/darwin-amd64-10_10
2018-07-11T01:08:56-5e70b13/darwin-amd64-race
2018-07-27T16:29:52-b39fb9e/darwin-amd64-10_10
2018-08-17T15:34:50-876c6d1/darwin-386-10_11
2018-08-17T15:34:50-876c6d1/darwin-amd64-10_10
2018-08-17T15:34:50-876c6d1/darwin-amd64-10_11
2018-08-21T04:39:22-80fe2e6/darwin-amd64-race
2018-08-21T04:50:21-2a5df06/darwin-386-10_11
2018-08-21T04:55:04-187a41d/darwin-amd64-10_10
2018-08-21T04:55:04-187a41d/darwin-amd64-10_11
2018-08-21T14:08:12-e8daca4/darwin-amd64-10_10
2018-08-22T22:11:24-ccb70bd/darwin-386-10_11
2018-08-24T23:02:01-aacc891/darwin-amd64-10_10
2018-08-24T23:02:31-523dc5a/darwin-amd64-10_10
2018-08-30T19:36:15-a2a8396/darwin-amd64-10_10
2018-08-30T19:36:15-a2a8396/darwin-amd64-race
2018-10-03T15:01:47-c96e3bc/darwin-amd64-10_10
2018-10-03T19:52:49-cbafcc5/darwin-amd64-10_10
2018-10-03T19:54:16-9a8372f/darwin-amd64-10_10
2018-10-03T19:54:29-c91ce3c/darwin-386-10_11
2018-10-03T19:54:29-c91ce3c/darwin-amd64-10_10
2018-10-03T19:54:29-c91ce3c/darwin-amd64-race
2018-10-03T20:13:35-112f28d/darwin-amd64-10_10

@ianlancetaylor ianlancetaylor added the release-blocker label Oct 3, 2018

@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Oct 3, 2018

@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

ianlancetaylor commented Oct 3, 2018

Any chance there was a recent change to whether the builders set GO_BUILDER_FLAKY_NET in the environment? Because the test does not fail in that way if that environment variable is set.

@katiehockman katiehockman changed the title net: Flaky test failing in darwin-amd64-10_10 net: flaky test failing in darwin-amd64-10_10 Oct 3, 2018

@mikioh

This comment has been minimized.

Sign in to view
Copy link
Contributor

mikioh commented Oct 3, 2018

Once http://golang.org/cl/102875 lands, I will smash the use of external DNS speakers such as rsc.io or some public full resolver then flaky tests disappear. For now, I have no spare time to debug the circumstances running the tests, also not sure there's a way to sneak in the (protected) circumstances.

@bradfitz bradfitz referenced this issue Oct 4, 2018

Closed

net: localhost pipes cause test hangs on macOS Sierra #25696

@andybons

This comment has been minimized.

Sign in to view
Copy link
Member

andybons commented Nov 28, 2018

@mikioh should we just disable this test until 1.13?
@mikioh

This comment has been minimized.

Sign in to view
Copy link
Contributor

mikioh commented Nov 29, 2018

Yes, please. Will try to allocate my spare time for Go 1.13 devel cycle.

@andybons andybons self-assigned this Nov 29, 2018

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

gopherbot commented Nov 29, 2018

Change https://golang.org/cl/151799 mentions this issue: net: skip flaky TestLookupDotsWithRemoteSource for now

gopherbot pushed a commit that referenced this issue Nov 30, 2018

@andybons
net: skip flaky TestLookupDotsWithRemoteSource on darwin 
Updates #27992

Change-Id: Ic327df7cc5002a3d537f9117559c25f30e1eab9c
Reviewed-on: https://go-review.googlesource.com/c/151799
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
9081229
@andybons

This comment has been minimized.

Sign in to view
Copy link
Member

andybons commented Nov 30, 2018

@mikioh done. Assigning back to you. Thanks.

@andybons andybons assigned mikioh and unassigned andybons Nov 30, 2018

@andybons andybons removed the release-blocker label Nov 30, 2018

@andybons andybons modified the milestones: Go1.12, Go1.13 Nov 30, 2018

@mikioh mikioh removed their assignment Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.