New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: TestLookupDotsWithRemoteSource is flaky #27992
Comments
Any chance there was a recent change to whether the builders set |
Once http://golang.org/cl/102875 lands, I will smash the use of external DNS speakers such as rsc.io or some public full resolver then flaky tests disappear. For now, I have no spare time to debug the circumstances running the tests, also not sure there's a way to sneak in the (protected) circumstances. |
@mikioh should we just disable this test until 1.13? |
Yes, please. Will try to allocate my spare time for Go 1.13 devel cycle. |
Change https://golang.org/cl/151799 mentions this issue: |
Updates #27992 Change-Id: Ic327df7cc5002a3d537f9117559c25f30e1eab9c Reviewed-on: https://go-review.googlesource.com/c/151799 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@mikioh done. Assigning back to you. Thanks. |
Here's the same failure mode on
|
|
I did some digging, and I believe that this flakiness is caused by the hard-coded timeout and attempt limits in Lines 41 to 45 in 825ff1e
On my Linux workstation, I would recommend:
|
We are getting flaky test failures in net. This has been somewhat rare in the past few months, but it has failed the last 5 builds, so probably worth looking into now.
Looks very related to #16865 closed 2 years ago.
The text was updated successfully, but these errors were encountered: