Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gomote: gomote push confused by non-ASCII filenames #28016

Open
bradfitz opened this issue Oct 4, 2018 · 2 comments
Open

x/build/cmd/gomote: gomote push confused by non-ASCII filenames #28016

bradfitz opened this issue Oct 4, 2018 · 2 comments
Labels
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 4, 2018

gomote push gets confused by non-ASCII filenames at least on Darwin:

$ gomote push user-bradfitz-darwin-amd64-10_12-0
2018/10/04 18:09:06 Deleting remote files: ["go/test/fixedbugs/issue27836.dir/Äfoo.go" "go/test/fixedbugs/issue27836.dir/Ämain.go"]
2018/10/04 18:09:06 Remote doesn't have "test/fixedbugs/issue27836.dir/Ämain.go"
2018/10/04 18:09:06 Remote doesn't have "test/fixedbugs/issue27836.dir/Äfoo.go"

These were added in https://golang.org/cl/138075

gomote just uses the underlying buildlet mechanisms, which are shared by the build system, so we should understand this more in case it's causing other problems or will cause problems down the road.

/cc @thanm @cherrymui @andybons @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Oct 4, 2018
@thanm
Copy link
Contributor

@thanm thanm commented Oct 4, 2018

When I submitted https://golang.org/cl/138075 I carefully checked the build dashboard for Darwin failures, and (not seeing any), assumed that the test was ok... sounds like that was a mistake. From your note it looks as though the test simply wasn't running (since it didn't get copied over)?

Loading

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Oct 4, 2018

@thanm, I'm not sure what's happening yet. But yeah, perhaps the test just isn't getting copied over or running.

Or more likely: it's getting written but the filesystem is changing the Unicode normalization form or otherwise re-encoding it, and that's confusing gomote which does not do any such thing.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants