Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: the WNOHANG, etc constants are weird and non-portable #2823

Closed
bradfitz opened this issue Jan 31, 2012 · 1 comment
Closed

os: the WNOHANG, etc constants are weird and non-portable #2823

bradfitz opened this issue Jan 31, 2012 · 1 comment
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jan 31, 2012

Problems with the bits in *os.Process Wait(options int)

1) they're non-portable
2) they're a mix of syscall bit numberspace and Go-assigned numbers (1 << 20 for
os.WRUSAGE)

We should clean this up somehow:

a) remove the options parameter to Wait
b) keep the options parameter, but document the bits as all Go-defined portable bits
(like FileMode)
c) document that they're all syscall bits and pass them along, but don't provide alias.
force callers to use syscall.WNOHANG, etc.  that leaves WRUSAGE, but we could just
always return that, and remove WRUSAGE.

d) ???
@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented Feb 10, 2012

Comment 1:

Status changed to Duplicate.

Merged into issue #2949.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.