Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: remove commented debug prints #28234

Closed
minaevmike opened this issue Oct 16, 2018 · 4 comments
Closed

database/sql: remove commented debug prints #28234

minaevmike opened this issue Oct 16, 2018 · 4 comments

Comments

@minaevmike
Copy link
Contributor

@minaevmike minaevmike commented Oct 16, 2018

there are some commented debug prints in database/sql package(like https://github.com/golang/go/blob/master/src/database/sql/sql.go#L600 and https://github.com/golang/go/blob/master/src/database/sql/sql.go#L570) , i think they can be deleted.

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Oct 16, 2018

Permalinks:

//println(fmt.Sprintf("removeDep(%T %p, %T %p)", x, x, dep, dep))

//println(fmt.Sprintf("addDep(%T %p, %T %p)", x, x, dep, dep))

@FiloSottile FiloSottile added this to the Go1.12 milestone Oct 16, 2018
@abhijitherekar
Copy link

@abhijitherekar abhijitherekar commented Oct 17, 2018

@FiloSottile Hi, Can I pick this?

@cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Oct 17, 2018

@abhijitherekar just send a CL

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 17, 2018

Change https://golang.org/cl/142877 mentions this issue: database/sql: remove commented debug prints

@gopherbot gopherbot closed this in 830f424 Oct 17, 2018
@golang golang locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.