Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: SameSite description is grammatically incorrect #28244

Closed
taylorza opened this issue Oct 17, 2018 · 21 comments

Comments

Projects
None yet
5 participants
@taylorza
Copy link

commented Oct 17, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go 1.11.x

Does this issue reproduce with the latest release?

The issue is with the documentation for net/http/SameSite documentation which was added in go 1.11

What did you expect to see?

I believe the following captures the intended description, without restructuring it too significantly

SameSite allows a server to define a cookie attribute making it impossible for the browser to send this cookie along with cross-site requests. The main goal is to mitigate the risk of cross-origin information leakage and provide some protection against cross-site request forgery attacks.

What did you see instead?

SameSite allows a server define a cookie attribute making it impossible to the browser send this cookie along with cross-site requests. The main goal is mitigate the risk of cross-origin information leakage, and provides some protection against cross-site request forgery attacks.

@bradfitz bradfitz changed the title net/http/SameSite: Description is grammatically incorrect net/http: SameSite description is grammatically incorrect Oct 17, 2018

@bradfitz bradfitz added this to the Unplanned milestone Oct 17, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

Want to send a change?

@taylorza

This comment has been minimized.

Copy link
Author

commented Oct 17, 2018

@bradfitz, I will send the change in.

@mbj36

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2018

@bradfitz I am new contributor to golang and i am slightly confused about the master branch....I have built my docs using godoc -http:=6060 and my master branch doesn't reflect what is present here - https://golang.org/pkg/net/http

Am i missing something, can you please point me to the right direction ?

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

@mbj36, I don't know what you've done or what your environment is so it's hard to help. I suspect the godoc you're running is using the wrong GOROOT. You can explicitly set the GOROOT environment variable to point to your master checkout path.

Also perhaps of help: https://golang.org/doc/contribute.html and the #gocontributing channel on the Gophers Slack.

@mbj36

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2018

@bradfitz Thanks for the reply.

This issue has been already fix here - https://tip.golang.org/pkg/net/http/#SameSite

@agnivade

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

If you want, you can still fix it by removing the s from provides.

The main goal is to mitigate the risk of cross-origin information leakage, and provides some protection against cross-site request forgery attacks.

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

13 similar comments
@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@gopherbot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Change https://golang.org/cl/143480 mentions this issue: doc: fix typo in cookie.go

@mbj36

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2018

@agnivade Fixed

@gopherbot gopherbot closed this in 6557af7 Nov 16, 2018

bradfitz added a commit that referenced this issue Nov 21, 2018

net/http: fix typo in the SameSite docs
Fixes #28244

Change-Id: I3ca36fd513f5543af0c8af254d267254c7d5e803
GitHub-Last-Rev: 83b16fa
GitHub-Pull-Request: #28302
Reviewed-on: https://go-review.googlesource.com/c/143480
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.