New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: add column info to export data #28259

Open
alandonovan opened this Issue Oct 17, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@alandonovan
Contributor

alandonovan commented Oct 17, 2018

None of the compiler's historical or present export data formats ($$, $$B, indexed) support column information, even though the compiler and the go/{token,ast,types}) packages are capable of producing and consuming this information. We should add it to the export data file using a suitably efficient encoding.

Otherwise various analysis tools will continue to report either the correct column, or column 1, depending on whether they are reporting the position of an object loaded from source or export data.

@ianthehat

@griesemer

This comment has been minimized.

Contributor

griesemer commented Oct 17, 2018

We should do this for the new indexed format. The old formats are not produced anymore .

@alandonovan

This comment has been minimized.

Contributor

alandonovan commented Oct 17, 2018

There is no golang.org/x/tools/go/internal/gcimporter/iexport.go, so go/types today can only export in the $$B format. Should I file a separate issue to port iexport.go to go/types?

@griesemer

This comment has been minimized.

Contributor

griesemer commented Oct 17, 2018

@alandonovan Yes, please. I think this would have to be an x/tools issue. The std lib doesn't support this mechanism even for the $BB format. (And I am about to remove the support for importing the $BB format from the std lib's gcimporter.)

@FiloSottile FiloSottile added this to the Unplanned milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment