Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/gcexportdata: support export using indexed format #28260

Open
alandonovan opened this issue Oct 17, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@alandonovan
Copy link
Contributor

commented Oct 17, 2018

We need to port the reader of indexed import data ($GOROOT/src/cmd/compile/internal/gc/iexport.go) to produce go/types data structures, analogous to what we do for the $$B format, which is deprecated.

@stamblerre

@gopherbot gopherbot added this to the Unreleased milestone Oct 17, 2018

@alandonovan alandonovan changed the title x/tools/go/gcexportdata: support export reading from indexed files x/tools/go/gcexportdata: support reading from indexed files Oct 17, 2018

@stamblerre

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2018

It seems like gcexportdata.Read is already reading indexed export data as of golang/tools@9a70f1f.

@alandonovan or @griesemer: is there anything else that needs to be done here?

@alandonovan alandonovan changed the title x/tools/go/gcexportdata: support reading from indexed files x/tools/go/gcexportdata: support export using indexed format Nov 20, 2018

@alandonovan

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2018

I corrected the issue title to mean "write", not "read".

@stamblerre

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2018

Thanks - I'll start working on this now.

@stamblerre stamblerre self-assigned this Nov 28, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Jan 8, 2019

Change https://golang.org/cl/156901 mentions this issue: go/internal/gcimporter: write export data for go/types

gopherbot pushed a commit to golang/tools that referenced this issue Jan 30, 2019

go/internal/gcimporter: write export data for go/types
Add an iexport.go (and corresponding iexport_test.go) file, which is an
adapted version of $GOROOT/src/cmd/compile/internal/gc/iexport.go. This
code writes exportdata for a *go/types.Package.

A majority of this code is directly copied from iexport.go, with a
change of types, while some of it had to be modified slightly.

Updates golang/go#28260

Change-Id: Ic7e8e99f0c6b886839280b410afffb037da8a79b
Reviewed-on: https://go-review.googlesource.com/c/156901
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.