Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: "user-defined object without package" error while typechecking crypto/tls #28282

Closed
ALTree opened this issue Oct 19, 2018 · 7 comments
Closed

Comments

@ALTree
Copy link
Member

@ALTree ALTree commented Oct 19, 2018

$ gotip version
go version devel +ff99a61e5e Fri Oct 19 14:11:52 2018 +0000 linux/amd64

The go/types test where it typechecks the whole standard library is currently failing on the crypto/tls package:

$ cd src/go/types
$ gotip test -run=Stdlib
--- FAIL: TestStdlib (9.24s)
    stdlib_test.go:243: /home/alberto/go/src/crypto/tls/handshake_client_test.go:1651:76: user-defined object without package: func (interface).Error() string
    stdlib_test.go:243: /home/alberto/go/src/crypto/tls/handshake_server_test.go:1439:76: user-defined object without package: func (interface).Error() string
FAIL
exit status 1
FAIL	go/types	9.263s

Spotted on the longtest builder.

cc @griesemer

@ALTree ALTree added this to the Go1.12 milestone Oct 19, 2018
@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 19, 2018

Yes, I just noticed this one, too, locally. Seems new.

Loading

@ALTree
Copy link
Member Author

@ALTree ALTree commented Oct 19, 2018

@griesemer I would like to keep the longtest builder green. Should I send a CL ignoring that error for the tls package? Obviously I won't bother if you plan to fix this in the near future.

Loading

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 19, 2018

Loading

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 19, 2018

Looking into this now.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 19, 2018

Change https://golang.org/cl/143478 mentions this issue: go/types: temporarily disable a verification in Stdlib test

Loading

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 19, 2018

This appears to be a subtle issue - won't have time today to track this down. Temporarily disabled part of the failing test per the above CL.

Loading

gopherbot pushed a commit that referenced this issue Oct 19, 2018
Keeps the longtest builder green for now.
Proper fix to come ASAP.

Also, reword an internal comment that could easily be misread.

Updates #28282.

Change-Id: I8f41c9faa5a3eb638e6204bae3ff374ed49e5177
Reviewed-on: https://go-review.googlesource.com/c/143478
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 22, 2018

Change https://golang.org/cl/143757 mentions this issue: go/types: copy embedded methods unchanged when completing interfaces

Loading

@gopherbot gopherbot closed this in e9b3941 Oct 22, 2018
@golang golang locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants