cmd/compile: "invalid recursive type" should abort

[bep]

This seems to be similar to #21273 (fixed in Go 1.10).

▶ go version
go version go1.11 darwin/amd64

package main

func main() {
	type int int
	type I int

	const i I = 1
}

The above fails with

./main.go:4:7: invalid recursive type int
./main.go:5:7: invalid recursive type I
./main.go:7:8: invalid constant type I

The above is clear enough in this small case, but I had this happen to me (again, an automatic refactoring gone wrong) in a bigger program and all I saw was a list of invalid constant type (that looked valid), and then too many errors.

[meirf]

Maybe this case should follow the same logic as here:

There's no need to tell me T is an invalid map key after telling me it's an invalid anything.

This case is trickier though since I is typed of the original error type.

cc @griesemer

[griesemer]

This is now (Go 1.18) reporting:

./prog.go:4:7: invalid recursive type int
	./prog.go:4:7: int refers to
	./prog.go:4:7: int

which seems reasonable. Closing as working as expected.