Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive/zip: API #2835

Closed
rsc opened this issue Feb 2, 2012 · 5 comments
Closed

archive/zip: API #2835

rsc opened this issue Feb 2, 2012 · 5 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Feb 2, 2012

Writer.Write should take a pointer receiver.
It is probably a matter of changing the embedded countWriter
to itself be a value, not a pointer.

I don't know what "It is safe to Open and Read from files concurrently." means.
@rsc
Copy link
Contributor Author

@rsc rsc commented Feb 2, 2012

Comment 1:

Labels changed: added priority-go1, removed priority-triage.

Owner changed to builder@golang.org.

Status changed to Accepted.

@rsc
Copy link
Contributor Author

@rsc rsc commented Feb 2, 2012

Comment 2:

Labels changed: added go1-must.

@adg
Copy link
Contributor

@adg adg commented Feb 3, 2012

Comment 3:

Owner changed to @adg.

@adg
Copy link
Contributor

@adg adg commented Feb 8, 2012

Comment 4:

Status changed to Started.

@adg
Copy link
Contributor

@adg adg commented Feb 8, 2012

Comment 5:

This issue was closed by revision 0a6e246.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 8, 2012
@rsc rsc assigned adg Feb 8, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed priority-go1 labels Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.