x/tools/cmd/goimports: goimports destroys import groups

[gbbr]

There have been some rather unusual changes to goimports lately. Is this what is expected here?

Before running goimports:

import (
	"context"
	"fmt"
	"io"
	"net"
	"testing"
	"time"

	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/mocktracer"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"

	"github.com/mongodb/mongo-go-driver/bson"
	"github.com/mongodb/mongo-go-driver/core/result"
	"github.com/mongodb/mongo-go-driver/core/wiremessage"
	"github.com/mongodb/mongo-go-driver/mongo"
	"github.com/mongodb/mongo-go-driver/mongo/clientopt"

	"github.com/stretchr/testify/assert"
)

After:

import (
	"context"
	"fmt"
	"io"
	"net"
	"testing"
	"time"

	"github.com/mongodb/mongo-go-driver/bson"
	"github.com/mongodb/mongo-go-driver/core/result"
	"github.com/mongodb/mongo-go-driver/core/wiremessage"
	"github.com/mongodb/mongo-go-driver/mongo"
	"github.com/mongodb/mongo-go-driver/mongo/clientopt"
	"github.com/stretchr/testify/assert"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/mocktracer"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
)

Is this really what we want? Isn't it better to allow separating standard library, same package and external? This gets even worse for larger projects.

I'd like to propose keeping space separated groups, just like before.

[hyangah]

Is this a result of the recent commit for #20818?

[agnivade]

@gbbr - @bradfitz just reverted the change for #20818. Could you get the latest and check again ?

[gbbr]

Yep, fixed. Thanks.