Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: API #2843

Closed
rsc opened this issue Feb 2, 2012 · 3 comments
Closed

database/sql: API #2843

rsc opened this issue Feb 2, 2012 · 3 comments
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Feb 2, 2012

Doc comment for DB.Driver says DriverDatabase, should say Driver.

ScanInto and ScannerInto are awkward names in a public API.  Maybe this operation
can be called Load?  Also name the argument src to make clear that
the receiver is the destination.

// A Loader can initialize itself by loading data from a driver.Value.
type Loader interface {
    Load(src driver.Value) error
}

ErrTransactionFinished -> ErrTxDone.

The Stmt.QueryRow example should say Scan(&name) not Scan(&s).
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 9, 2012

Comment 1:

There is precedent for it being named Scan, though, right?
http://weekly.golang.org/pkg/fmt/#Scanner
@rsc
Copy link
Contributor Author

@rsc rsc commented Feb 9, 2012

Comment 2:

Scan/Scanner is fine; it's ScanInto and ScannerInto that I object to.
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 9, 2012

Comment 3:

This issue was closed by revision 6bdd791.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 9, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed priority-go1 labels Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.