math/big: typo in formula used in comment #28444
Labels
Comments
|
Change https://golang.org/cl/145280 mentions this issue: |
|
@ALTree Thanks a lot |
gopherbot
pushed a commit
that referenced
this issue
Oct 28, 2018
The function documentation was wrong, it was using a wrong parameter. This change replaces it with the right parameter. The wrong formula was: q = (u1<<_W + u0 - r)/y The function has got a parameter "v" (of type Word), not a parameter "y". So, the right formula is: q = (u1<<_W + u0 - r)/v Fixes #28444 Change-Id: I82e57ba014735a9fdb6262874ddf498754d30d33 Reviewed-on: https://go-review.googlesource.com/c/145280 Reviewed-by: Robert Griesemer <gri@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
At line 85 in
src/math/big/arith.gofile, it should beq = (u1<<_W + u0 - r)/vrather thanq = (u1<<_W + u0 - r)/yWhat version of Go are you using (
go version)?go version go1.10.1 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env)?What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
What did you see instead?
The text was updated successfully, but these errors were encountered: