New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: wait-author tag not being auto-removed from updated CLs #28510

Open
bradfitz opened this Issue Oct 31, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@bradfitz
Member

bradfitz commented Oct 31, 2018

Gopherbot is supposed to be removing the wait-author tag on CLs when an OP replies or updates a new patchset.

I've noticed it hasn't been. Here's an example:

https://go-review.googlesource.com/c/go/+/142537

I added the tag at https://go-review.googlesource.com/c/go/+/142537#message-38fe2a310757d0fde272356e560843068aa980c3 and then PS2 was uploaded, but the wait-author tag remains.

/cc @dmitshur @katiehockman @bcmills

@bradfitz bradfitz added the NeedsFix label Oct 31, 2018

@gopherbot gopherbot added this to the Unreleased milestone Oct 31, 2018

@gopherbot gopherbot added the Builders label Oct 31, 2018

@dmitshur

This comment has been minimized.

Member

dmitshur commented Oct 31, 2018

This is likely caused by issue #28318.

If you do go run golang.org/x/build/maintner/cmd/maintserve -http=localhost:8080, then visit http://localhost:8080/go.googlesource.com/go and search for "#142537", you'll see that maintner reports that CL as not having any tags:

image

As a result, gopherbot doesn't believe that the CL has a wait-author tag, so it doesn't try to remove it.

@dmitshur

This comment has been minimized.

Member

dmitshur commented Oct 31, 2018

A simple program that confirms it:

package main

import (
	"context"
	"fmt"
	"log"

	"golang.org/x/build/maintner/godata"
)

func main() {
	corpus, err := godata.Get(context.Background())
	if err != nil {
		log.Fatalln(err)
	}
	cl := corpus.Gerrit().Project("go.googlesource.com", "go").CL(142537)
	fmt.Printf("tags = %q\n", cl.Meta.Hashtags())

	// Output:
	// tags = ""
}
@Skarlso

This comment has been minimized.

Skarlso commented Nov 15, 2018

Note here too. I volunteered for the fix of the corresponding issue #25253.

@Skarlso

This comment has been minimized.

Skarlso commented Nov 17, 2018

Tags are now correctly displayed on a local test run:

screenshot 2018-11-17 at 21 01 43

And the linked issue:

screenshot 2018-11-17 at 21 05 40

screenshot 2018-11-17 at 21 04 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment