Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: add test for Windows Dedup volumes #28547

Open
alexbrainman opened this issue Nov 2, 2018 · 1 comment
Open

os: add test for Windows Dedup volumes #28547

alexbrainman opened this issue Nov 2, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. help wanted new-builder OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unplanned

Comments

@alexbrainman
Copy link
Member

In recent CL 143578, I was going to remove some code that I thought did nothing. My change would have made all files on Windows Dedup volumes ( https://docs.microsoft.com/en-us/windows-server/storage/data-deduplication/overview ) look like symlinks.

Luckily @kolyshkin pointed my mistake ( #22579 (comment) ). I built Windows instance on Gogle Cloud with extra disk attached as D: drive and with Dedup option on, to test my CL.

I wonder, if we can have one of our Windows builders have small extra disk with Dedup on. Then we could write some appropriate tests that run on that builder.

/cc @bradfitz @johnsonj

Alex
@bradfitz bradfitz added Builders x/build issues (builders, bots, dashboards) new-builder Testing An issue that has been verified to require only test changes, not just a test failure. labels Nov 2, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Nov 2, 2018

/cc @dmitshur

@bradfitz bradfitz added FeatureRequest Issues asking for a new feature that does not need a proposal. help wanted labels Nov 2, 2018
@alexbrainman alexbrainman mentioned this issue Dec 16, 2018
Closed
@seankhliao seankhliao added this to the Unplanned milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. help wanted new-builder OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@bradfitz @alexbrainman @seankhliao