cmd/link: suspicious use of (*cmd/internal/bio/buf.Reader).Seek

[alandonovan]

While a running a recent test of vet, it flagged the (*buf.Reader).Seek method as not having a proper return type (int64, error). Instead it handles errors by calling log.Fatal, yet most callers of this function seem to assume it returns a negative number to indicate failure.

Someone who knows this code should probably audit it.

[bradfitz]

I remember some clean-ups some time ago to move towards using the stdlib types. I assume the old seeker was C-ish and returned negative and we didn't convert it all when moving to Go stuff.

/cc @davecheney

[alexyak1]

Fix here https://go-review.googlesource.com/c/go/+/151043. On review now

[gopherbot]

Change https://golang.org/cl/151043 mentions this issue: math: Fix suspicious use of (*cmd/internal/bio/buf.Reader).Seek