Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: trybot-result-changers Gerrit group doesn't allow removing TryBot-Result votes #28565

Closed
dmitshur opened this issue Nov 2, 2018 · 5 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 2, 2018

I am a member of this group, yet I can't remove TryBot-Result votes right now. E.g.:

This is needed to be able to force a trybot re-run.

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Jan 21, 2019

I think @andybons has resolved the issue of some of us not being able to remove TryBot-Result votes recently, see #29285 (comment). E.g., I have that ability now:

Do we still need the trybot-result-changers Gerrit group for anything? I don't believe @andybons's solution used it.

I'll leave this issue open to decide what to do with trybot-result-changers group, but otherwise I believe this is resolved now.

@andybons
Copy link
Member

@andybons andybons commented Jan 22, 2019

I created a new group may-remove-reviewer that is the umbrella permission for removing reviewers, ccs, and labels. We can either make trybot-result-changers a child of that group or remove it.

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Nov 20, 2019

/cc @FiloSottile FYI, since you're changing or considering changing Gerrit permissions.

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Nov 20, 2019

@dmitshur Is this still not working as intended?

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Nov 20, 2019

The current status of the issue is:

I'll leave this issue open to decide what to do with trybot-result-changers group, but otherwise I believe this is resolved now.

If we don't need an open issue to track that task, this can be closed.

@andybons andybons closed this Nov 20, 2019
@golang golang locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants