text/template: can invoke method of pipeline result value

[mei-rune]

can invoke method of pipeline result value

package main

import (
 "fmt"
  "bytes"
  "html/template"
)


type TextField struct {
    name string
    value string
}

func (field *TextField) SetValue( value string) *TextField {
   field.value = value
   return field
}

func (field *TextField) Render() template.HTML {
  return  template.HTML(`<input type="text" name="`+field.name+`">`+field.value+`</input>`)
}

func NewTextField(name string) *TextField  {
   return &TextField{name: name}
}

var funcs = template.FuncMap{
 "text_field": NewTextField,
 }


func main() {
     txt := `{{text_field "username" |SetValue .value |Render }}`

      var buf bytes.Buffer
      var tpl, _ = template.New("main").Funcs(funcs).Parse(txt)
     tpl.Execute(&buf, map[string]interface{}{"value": "world"});
	fmt.Println(buf.String())
	//Output <input type="text" name="username">world</input>
}

text_field return *TextField ptr,
"|SetValue .value" will invoke "func (field *TextField) SetValue( value string)"
"|Render" will invoke "func (field *TextField) Render()"

like

// {{text_field "username" |SetValue .value |Render }}
NewTextField("username").SetValue(xxxx).Render()

if method isnot exists then execute old behaviour.

My English is poor.
我的意恩是
现在模板将符号 '|' 之前的执行结果作来下一个方法(function)的最后一个参数， 那能不能将 '|' 后的方法作为前一次结果的成员函数(method）,

[mvdan]

@runner-mei I assume that this is a feature request to be able to chain methods via pipelines, is that correct?

Have you considered doing something like {{with $x := text_field "username" | call $x.Render }}?

Also note that currently the parser is the one that rejects undefined functions. If this feature were to get implemented, we'd have to drop that check entirely, as it would be impossible to tell if a function is defined or not at parse time.

I personally think this is not a good idea. It seems like you can already accomplish the task with the current template language, and we don't want to complicate the language unless strictly necessary.

/cc @robpike

[mei-rune]

@mvdan yes, this is a feature request to be able to chain methods via pipelines.

no, We didn't give up that check entirely，result of function text_field is *TextField (not interface{}), We can try to obtain the return value type and check it.

[robpike]

I would prefer not to do this. The grammar is subtle enough as is, the execution logic even more so, and it is easy, as shown above, to achieve the desired result with the existing template language.

[mei-rune]

@robpike Now the grammar is insufficient, it is cumbersome。

It's a bug? the following statements are incorrect, they run ok and don't have any output

{{with $x := text_field "username" | call $x.SetValue .value | call $x.Render }}{{end}}
{{with $x := text_field "username" | call $x.SetValue .value | call $x.Render }}{{$x}}{{end}}
{{with $x := text_field "username"}}{{call $x.SetValue .value}}{{call $x.Render }}{{end}}
{{with $x := text_field "username" }} {{ $x.SetValue .value }} {{ $x.Render}} {{end}}
{{with $x := text_field "username" |  $x.SetValue .value |  $x.Render }}{{end}}
{{with $x := text_field "username" |  $x.SetValue .value |  $x.Render }}{{$x}}{{end}}
{{with text_field "username"}}{{ $.SetValue .value |  $.Render }}{{end}}
{{with text_field "username"}}{{call  $.SetValue .value  }}{{ call $.Render }}{{end}}

only the following statements are correct

{{with $x := text_field "username" }} {{ $x.Render}} {{end}}  // but cannot invoke SetValue  in the with block

[mei-rune]

or add '@' prefix

{{text_field "username" |@SetValue .value |@Render }}

[seankhliao]

sounds like a won't do.