New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: reconsider NaCL builders on subrepos #28582

Closed
dmitshur opened this Issue Nov 3, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@dmitshur
Member

dmitshur commented Nov 3, 2018

I'm not seeing an issue about this, so filing one to track this.

NaCL builders got added to subrepo trybots as part of changes in CL 145157, which got deployed a few days ago. Brad noticed it earlier and told me:

also I need to remove nacl trybots from x/net etc
that was a mistake I think

They seem to be failing on many x/tools trybot runs, e.g., https://go-review.googlesource.com/c/tools/+/147317#message-0b65ea2ab17f9e28f0519d84b8bb646345441b6a, making the real failures harder to see.

Adding NeedsDecision because I'm not 100% confident what's the best resolution here, and looking for confirmation.

/cc @bradfitz @heschik

@gopherbot gopherbot added this to the Unreleased milestone Nov 3, 2018

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 4, 2018

Decision: don't run nacl for subrepos. There's no mechanism to package their testdata files up anyway.

@bradfitz bradfitz added the NeedsFix label Nov 4, 2018

@gopherbot gopherbot removed the NeedsDecision label Nov 4, 2018

@gopherbot

This comment has been minimized.

gopherbot commented Nov 4, 2018

Change https://golang.org/cl/147337 mentions this issue: dashboard: revert accidental inclusion of nacl subrepo trybots

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 4, 2018

Deployed.

Farmer was:

21h27m35s. Version 906dcfd58886df4b3156fd9fa9d51f9767bd66f6.

Now:

Uptime 1s. Version 9f6998b87f0ce9198930a0a7eb5e5b86ae8b7802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment