/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make.bat: autodetect GOROOT_BOOTSTRAP #28641

Open
FiloSottile opened this Issue Nov 7, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Go1.12
3 participants
@FiloSottile @crvv @gopherbot
@FiloSottile
Member

FiloSottile commented Nov 7, 2018

On Unix we automatically use $(go env GOROOT) as GOROOT_BOOTSTRAP (see #14339). We should do that on Windows as well, where it's harder to set env vars, and for consistency.

Make sure that there are checks in place to prevent $GOROOT_BOOTSTRAP == $GOROOT.

@FiloSottile FiloSottile added help wanted OS-Windows NeedsFix labels Nov 7, 2018

@FiloSottile FiloSottile added this to the Go1.12 milestone Nov 7, 2018

@crvv

This comment has been minimized.

Sign in to view
Contributor

crvv commented Nov 8, 2018

There is a CL for this.
https://go-review.googlesource.com/c/go/+/96455
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Nov 29, 2018

Change https://golang.org/cl/96455 mentions this issue: build: add default GOROOT_BOOTSTRAP in Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment