Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make.bat: autodetect GOROOT_BOOTSTRAP #28641

Open
FiloSottile opened this issue Nov 7, 2018 · 3 comments

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Nov 7, 2018

On Unix we automatically use $(go env GOROOT) as GOROOT_BOOTSTRAP (see #14339). We should do that on Windows as well, where it's harder to set env vars, and for consistency.

Make sure that there are checks in place to prevent $GOROOT_BOOTSTRAP == $GOROOT.

@crvv

This comment has been minimized.

Copy link
Contributor

@crvv crvv commented Nov 8, 2018

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 29, 2018

Change https://golang.org/cl/96455 mentions this issue: build: add default GOROOT_BOOTSTRAP in Windows

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 20, 2019

Change https://golang.org/cl/208197 mentions this issue: make.bat: set go env GOROOT as default for GOROOT_BOOTSTRAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.