Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upmake.bat: autodetect GOROOT_BOOTSTRAP #28641
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
There is a CL for this. |
This comment has been minimized.
This comment has been minimized.
Change https://golang.org/cl/96455 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
Change https://golang.org/cl/208197 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On Unix we automatically use
$(go env GOROOT)
asGOROOT_BOOTSTRAP
(see #14339). We should do that on Windows as well, where it's harder to set env vars, and for consistency.Make sure that there are checks in place to prevent
$GOROOT_BOOTSTRAP == $GOROOT
.