Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/app: build dashboard for subrepos is confusing #28643

Open
matloob opened this issue Nov 7, 2018 · 5 comments
Open

x/build/app: build dashboard for subrepos is confusing #28643

matloob opened this issue Nov 7, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@matloob
Copy link
Contributor

@matloob matloob commented Nov 7, 2018

cc @dmitshur

The build dashboard for subrepos is a bit hard to read. The the go distribution that's tested against is given as a commit hash, which is sometimes useful but most of the time I care about which version of Go is tested against especially since multiple versions of Go appear in the dashboard.

It's a little hard to tell which version of Go is tested against which version of the subrepo. It might be helpful to combine the rows for a given version of the subrepo.

@gopherbot gopherbot added this to the Unreleased milestone Nov 7, 2018
@gopherbot gopherbot added the Builders label Nov 7, 2018
@dmitshur dmitshur self-assigned this Nov 8, 2018
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 8, 2018

Which page are you talking about?

This one? https://build.golang.org/?repo=golang.org%2fx%2ftools

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 8, 2018

@bradfitz Yes, that's the page Michael was referring to.

@matloob
Copy link
Contributor Author

@matloob matloob commented Nov 8, 2018

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 22, 2020

Change https://golang.org/cl/244137 mentions this issue: app/appengine: stop hiding some tested configurations for x repos

gopherbot pushed a commit to golang/build that referenced this issue Jul 22, 2020
The build dashboard can be used to view builds for the main Go repo
and other golang.org/x repos. The isUntested invocation was invalid
for repos other than the main one, which was causing results for some
tested configurations to become hidden (incorrectly replaced by '•').

Larger changes are needed before there's sufficient data to compute
the GoBranch value for all repos reliably, so for now, just update
the isUntested invocation to apply only for the main repo.

This prioritizes the ability to view test results over the ability
to see that some builds are intentionally missing because they are
configured not to run. Doing both is a part of future work.

For golang/go#40290.
For golang/go#34744.
For golang/go#28643.

Change-Id: Id43cb47abacb1036f578efbb8232ae17ad40eca9
Reviewed-on: https://go-review.googlesource.com/c/build/+/244137
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur dmitshur self-assigned this Jul 26, 2020
@dmitshur dmitshur removed the help wanted label Jul 26, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 28, 2020

Change https://golang.org/cl/245277 mentions this issue: maintner/maintnerd/maintapi/version: support beta and RC release tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.