x/tools/cmd/goimports: Goimports removes valid import paths when pkgName != dirName

[VojtechVitek]

What version of Go are you using (go version)?

$ go version
go version go1.11.1 darwin/amd64

Does this issue reproduce with the latest release?

go get -u -v golang.org/x/tools/cmd/goimports

As of writing, goimports are on this commit: golang/tools@4ca4995

Regression reproducer

Please, see a reproducer repo: https://github.com/VojtechVitek/goimports-bug

Issue

Seems like latest goimports started removing completely valid import paths when package name doesn't match the pkg's directory name.

[VojtechVitek]

Probably a duplicate of #28645, which was submitted while I was writing this down.

[heschi]

Yep, should be fixed now. Sorry for the trouble.

[VojtechVitek]

Thanks for the quick fix!

[requilence]

@heschik Just to make you know, it is still not fixed at 1.11.4
And I can't find a fix at goimports repo

[heschi]

Most of goimports' code is in x/tools/imports. The bad change was rolled back in golang/tools@a28dfb4. If you're still having problems, please file a new bug with more detail, ideally a repro case.