Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: add command to ping owners of the package #28657

Open
ysmolsky opened this Issue Nov 8, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@ysmolsky
Copy link
Member

ysmolsky commented Nov 8, 2018

It would be good to ping owners of the package in the ticket without remembering who is the owner of it. What if one could say:

@gopherbot please ping owners 
@gopherbot please ping owners to critique the solution

And then gopher would produce something like:

@name has asked @firstowner @secondowner to review this issue
@name has asked @firstowner @secondowner to critique the solution

@gopherbot gopherbot added this to the Unreleased milestone Nov 8, 2018

@ysmolsky

This comment has been minimized.

Copy link
Member Author

ysmolsky commented Nov 8, 2018

Should this be semiautomatic? If the issue does not mention anybody and nobody has replied after 1 week then bot should trigger this automatically.

EDIT: bot should not trigger this automatically for issues that were already triaged (have according labels like NeedsFix, etc).

@agnivade

This comment has been minimized.

Copy link
Member

agnivade commented Nov 8, 2018

I think this was raised earlier (the "gopherbot pinging owners automatically" part), although I can't find it now.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented Nov 9, 2018

Seems to me that once I've been mentioned in an issue, every comment on the issue sends me an e-mail. So I'm not sure what an explicit gopherbot ping command would do that isn't already done by simply commenting on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.