Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upx/build: “Gerrit User XXX” displayed instead of actual name in Gerrit messages #28663
Comments
andybons
changed the title
bradfitz
changed the title
andybons
changed the title
This comment has been minimized.
This comment has been minimized.
|
This also affects dev.golang.org. |
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/148557 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Nov 8, 2018
This change deletes the OwnerName method on GerritCL, since Gerrit's format for its NoteDB backing store changed to display "Gerrit User NNN" instead of the proper display name in the meta commit. Update golang/go#28663 Change-Id: Ifa64ca2b2694b17e888451582b9c63f3f37280a9 Reviewed-on: https://go-review.googlesource.com/c/148557 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/148560 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
|
This should take effect on Nov 9 00:00 UTC in that all new Gerrit comments after that time will have the correct display name. dev.golang.org/reviews is fixed now. |
This comment has been minimized.
This comment has been minimized.
|
This is now fixed for all new comments. Sorry for the inconvenience, @rsc. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the quick fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#28659 (comment) says "Message from Gerrit User 5056". This needs to be fixed, and soon.
It's easy to fix - the usual Gerrit REST API ChangeInfo uses the right names. I'm perplexed as to why the maintner feed says these things but at least the bot could re-fetch the actual Gerrit comments directly from Gerrit (only when it needs to post one to GitHub, so fairly low rate) to find out real names.
#28662 means that from Gerrit I can't tell who is writing the CL and this bug means that from GitHub I can't tell who is reviewing the CL. This is not really an acceptable review process.