Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: “Gerrit User XXX” displayed instead of actual name in Gerrit messages #28663
#28659 (comment) says "Message from Gerrit User 5056". This needs to be fixed, and soon.
It's easy to fix - the usual Gerrit REST API ChangeInfo uses the right names. I'm perplexed as to why the maintner feed says these things but at least the bot could re-fetch the actual Gerrit comments directly from Gerrit (only when it needs to post one to GitHub, so fairly low rate) to find out real names.
#28662 means that from Gerrit I can't tell who is writing the CL and this bug means that from GitHub I can't tell who is reviewing the CL. This is not really an acceptable review process.
This change deletes the OwnerName method on GerritCL, since Gerrit's format for its NoteDB backing store changed to display "Gerrit User NNN" instead of the proper display name in the meta commit. Update golang/go#28663 Change-Id: Ifa64ca2b2694b17e888451582b9c63f3f37280a9 Reviewed-on: https://go-review.googlesource.com/c/148557 Reviewed-by: Brad Fitzpatrick <email@example.com>