Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: “Gerrit User XXX” displayed instead of actual name in Gerrit messages #28663

Closed
rsc opened this issue Nov 8, 2018 · 6 comments
Closed

x/build: “Gerrit User XXX” displayed instead of actual name in Gerrit messages #28663

rsc opened this issue Nov 8, 2018 · 6 comments
Labels
Builders FrozenDueToAge NeedsFix Soon
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Nov 8, 2018

#28659 (comment) says "Message from Gerrit User 5056". This needs to be fixed, and soon.

It's easy to fix - the usual Gerrit REST API ChangeInfo uses the right names. I'm perplexed as to why the maintner feed says these things but at least the bot could re-fetch the actual Gerrit comments directly from Gerrit (only when it needs to post one to GitHub, so fairly low rate) to find out real names.

#28662 means that from Gerrit I can't tell who is writing the CL and this bug means that from GitHub I can't tell who is reviewing the CL. This is not really an acceptable review process.
@rsc rsc added this to the Unreleased milestone Nov 8, 2018
@andybons andybons added NeedsFix Soon labels Nov 8, 2018
@andybons andybons changed the title github PR bot does not include real names in github messages x/build/maintner: “Gerrit User XXX” displayed instead of actual name in Gerrit messages Nov 8, 2018
@gopherbot gopherbot added the Builders label Nov 8, 2018
@bradfitz bradfitz changed the title x/build/maintner: “Gerrit User XXX” displayed instead of actual name in Gerrit messages x/build/cmd/gerritbot: “Gerrit User XXX” displayed instead of actual name in Gerrit messages Nov 8, 2018
@andybons andybons changed the title x/build/cmd/gerritbot: “Gerrit User XXX” displayed instead of actual name in Gerrit messages x/build: “Gerrit User XXX” displayed instead of actual name in Gerrit messages Nov 8, 2018
@andybons
Copy link
Member

@andybons andybons commented Nov 8, 2018

This also affects dev.golang.org.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 8, 2018

Change https://golang.org/cl/148557 mentions this issue: maintner, devapp: display proper owner names instead of Gerrit User NNN

gopherbot pushed a commit to golang/build that referenced this issue Nov 8, 2018
@andybons
maintner, devapp: display proper owner names instead of Gerrit User NNN
5df336c 
This change deletes the OwnerName method on GerritCL, since Gerrit's
format for its NoteDB backing store changed to display "Gerrit User NNN"
instead of the proper display name in the meta commit.

Update golang/go#28663

Change-Id: Ifa64ca2b2694b17e888451582b9c63f3f37280a9
Reviewed-on: https://go-review.googlesource.com/c/148557
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 8, 2018

Change https://golang.org/cl/148560 mentions this issue: cmd/gerritbot: post proper display name of message author to GitHub

@andybons
Copy link
Member

@andybons andybons commented Nov 8, 2018 •
edited

This should take effect on Nov 9 00:00 UTC in that all new Gerrit comments after that time will have the correct display name. dev.golang.org/reviews is fixed now.

@andybons
Copy link
Member

@andybons andybons commented Nov 9, 2018

This is now fixed for all new comments.

Sorry for the inconvenience, @rsc.

@rsc
Copy link
Contributor Author

@rsc rsc commented Nov 14, 2018

Thanks for the quick fix.

@golang golang locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders FrozenDueToAge NeedsFix Soon
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rsc @andybons @gopherbot