Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccgo: prometheus doesn't build with gccgo, builds fine with gc #28665

Closed
glaubitz opened this issue Nov 8, 2018 · 3 comments
Assignees
Milestone

Comments

@glaubitz
Copy link

@glaubitz glaubitz commented Nov 8, 2018

Trying to build prometheus with gccgo fails with:

golang.org/x/text/unicode/bidi
google.golang.org/grpc/codes
golang.org/x/sys/unix
# github.com/prometheus/prometheus/pkg/runtime
src/github.com/prometheus/prometheus/pkg/runtime/limits_default.go:27:31: error: integer constant overflow
 var unlimited int64 = syscall.RLIM_INFINITY
                               ^
golang.org/x/oauth2/jws
google.golang.org/grpc/grpclog
github.com/grpc-ecosystem/grpc-gateway/utilities

Full log available at: https://people.debian.org/~glaubitz/gccgo-logs/prometheus_2.4.3+ds-2_amd64.build

@gopherbot gopherbot added this to the Gccgo milestone Nov 8, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 9, 2018

Change https://golang.org/cl/148697 mentions this issue: syscall: change RLIM_INFINITY from 0xffffffffffffffff to -1

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 9, 2018

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 9, 2018

Fixed on GCC trunk and GCC 7 and GCC 8 branches.

kraj pushed a commit to kraj/gcc that referenced this issue Nov 9, 2018
    
    For compatibility with the gc toolchain's syscall package.
    
    Fixes golang/go#28665
    
    Reviewed-on: https://go-review.googlesource.com/c/148697


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-7-branch@265972 138bc75d-0d04-0410-961f-82ee72b054a4
kraj pushed a commit to kraj/gcc that referenced this issue Nov 9, 2018
    
    For compatibility with the gc toolchain's syscall package.
    
    Fixes golang/go#28665
    
    Reviewed-on: https://go-review.googlesource.com/c/148697


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-8-branch@265973 138bc75d-0d04-0410-961f-82ee72b054a4
kraj pushed a commit to kraj/gcc that referenced this issue Nov 9, 2018
    
    For compatibility with the gc toolchain's syscall package.
    
    Fixes golang/go#28665
    
    Reviewed-on: https://go-review.googlesource.com/c/148697


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@265974 138bc75d-0d04-0410-961f-82ee72b054a4
@golang golang locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.