Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/pubsubhelper: use cloud pubsub for Gerrit instead of email #28675

Open
bradfitz opened this issue Nov 8, 2018 · 4 comments
Open

x/build/cmd/pubsubhelper: use cloud pubsub for Gerrit instead of email #28675

bradfitz opened this issue Nov 8, 2018 · 4 comments
Labels
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 8, 2018

When I wrote pubsubhelper, Gerrit didn't support Cloud Pub Sub, so we had to parse emails to get live notifications out of Gerrit.

But @andybons pointed out that now it does, so we should move to it.

Low priority, but would be a nice cleanup.

@gopherbot gopherbot added this to the Unreleased milestone Nov 8, 2018
@gopherbot gopherbot added the Builders label Nov 8, 2018
@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented Nov 8, 2018

For Google internal docs on how to set it up for our Gerrit instead, see http://go/golang-issue-28675-docs

@andybons

This comment has been minimized.

@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented May 29, 2019

@andybons, IIRC, you said their pubsub topic today is still insufficient? It does't include all the NoteDB changes or something?

@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented May 29, 2019

(For background for others, we currently run https://pubsubhelper.golang.org/ which is a fake email server that listens to Gerrit emails to know when things happen on Gerrit.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.