Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/analysis/internal/unitchecker: TestIntegration fails #28676

Closed
bradfitz opened this issue Nov 8, 2018 · 2 comments

Comments

@bradfitz
Copy link
Member

@bradfitz bradfitz commented Nov 8, 2018

TestIntegration fails, even with Go 1.12:

--- FAIL: TestIntegration (0.10s)
    unitchecker_test.go:85: got exit code -1, want 2
    unitchecker_test.go:96: got <<>>, want <<# a
        testdata/src/a/a.go:4:11: call of MyFunc123(...)
        # b
        testdata/src/b/b.go:6:13: call of MyFunc123(...)
        testdata/src/b/b.go:7:11: call of MyFunc123(...)
        >>
    unitchecker_test.go:100: err=<nil> stderr=<<>
FAIL
FAIL    golang.org/x/tools/go/analysis/internal/unitchecker     0.113s

I'm going to skip this test for now to get the tree usable for other people.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 8, 2018

Change https://golang.org/cl/148637 mentions this issue: go/packages, go/analysis/internal/unitchecker: skip broken tests for now

gopherbot pushed a commit to golang/tools that referenced this issue Nov 8, 2018
Updates golang/go#28609
Updates golang/go#28676

Change-Id: Id0fbc6cb0ce14aed9b20afcd0488708df33d5a62
Reviewed-on: https://go-review.googlesource.com/c/148637
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 15, 2018

Change https://golang.org/cl/149697 mentions this issue: go/analysis/internal/unitchecker: reenable integration test

@golang golang locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.