Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: refine calcHasCall's handling of ODIV and OMOD #28698

Open
josharian opened this issue Nov 9, 2018 · 2 comments
Open

cmd/compile: refine calcHasCall's handling of ODIV and OMOD #28698

josharian opened this issue Nov 9, 2018 · 2 comments
Labels
NeedsFix Suggested
Milestone
Backlog

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Nov 9, 2018

@cherrymui noted in the review of CL 148837 that on non-soft-float platforms, when working with floats, ODIV and OMOD won't panic. We should handle them a bit more precisely in calcHasCall.
@josharian josharian added this to the Go1.13 milestone Nov 9, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 11, 2019

Change https://golang.org/cl/166937 mentions this issue: cmd: handle floats for ODIV better

@andybons andybons removed this from the Go1.13 milestone Jul 8, 2019
@andybons andybons added this to the Go1.14 milestone Jul 8, 2019
@aenkya
Copy link

@aenkya aenkya commented Oct 4, 2019

I'd like to take a go at this 👋 🙂

@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Suggested
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@josharian @rsc @andybons @aenkya @gopherbot