New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: some CLs exp subrepo left strange active trybots running #28714

Closed
dmitshur opened this Issue Nov 10, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@dmitshur
Member

dmitshur commented Nov 10, 2018

A few CLs (147877, 147797, 146197) in the exp subrepo started trybots.

They each ended with a trybot run that started, but never finished. E.g.:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0d16b4a3

image

As a result, farmer shows 3 active trybot runs now, with -2 remaining builds each:

image

/cc @bradfitz

Reporting this for our reference, since I'm about to redeploy coordinator and we might lose this information.

@dmitshur

This comment has been minimized.

Member

dmitshur commented Nov 10, 2018

The "Builds Remaining" number calculation is clearly wrong. I've noticed it's sometimes wrong even elsewhere, for trybots that succeed properly. E.g., from this trybot run:

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 11, 2018

Fallout from #17626. Specifically from https://go-review.googlesource.com/c/build/+/143538/ ... before that CL the number of builders in a tryset was always equal to the number of try builders. Apparently I missed that we had made that assumption.

Easy enough fix.

@bradfitz bradfitz self-assigned this Nov 11, 2018

@dmitshur

This comment has been minimized.

Member

dmitshur commented Nov 11, 2018

Thanks for diagnosing the issue.

@gopherbot

This comment has been minimized.

gopherbot commented Nov 13, 2018

Change https://golang.org/cl/149437 mentions this issue: cmd/coordinator: fix trybot remaining builds count for subrepos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment