/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: list -json includes assembly files among CompiledGoFiles #28749

Open
alandonovan opened this Issue Nov 12, 2018 · 1 comment

Comments

Assignees

@bcmills bcmills

Labels
Projects
None yet
Milestone
  Go1.13
3 participants
@alandonovan @gopherbot @bcmills
@alandonovan
Contributor

alandonovan commented Nov 12, 2018 •
edited 

$ go version
go version devel +a4e958ff2d Mon Nov 12 13:44:06 2018 -0500 linux/amd64
$ go list -json -compiled reflect
{
        "Dir": "/usr/local/google/home/adonovan/goroot/src/reflect",
        "ImportPath": "reflect",
        "Name": "reflect",
...
        "GoFiles": [
                "deepequal.go",
                "makefunc.go",
                "swapper.go",
                "type.go",
                "value.go"
        ],
        "CompiledGoFiles": [
                "deepequal.go",
                "makefunc.go",
                "swapper.go",
                "type.go",
                "value.go",
                "asm_amd64.s"   // !
        ],
        "SFiles": [
                "asm_amd64.s"
        ],
...

@alandonovan alandonovan assigned bcmills Nov 12, 2018

@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Nov 13, 2018

Change https://golang.org/cl/149237 mentions this issue: go/packages: remove .s files from go list's CompiledGoFiles

gopherbot pushed a commit to golang/tools that referenced this issue Nov 13, 2018

@alandonovan
go/packages: remove .s files from go list's CompiledGoFiles 
This is a workaround for a go list regression that broke
go/packages but went unnoticed by because of a missing
call to packages.PrintErrors, added here.

Updates golang/go#28749

Change-Id: I1819a6143134a422791106ac037d3458ef864322
Reviewed-on: https://go-review.googlesource.com/c/149237
Reviewed-by: Ian Cottrell <iancottrell@google.com>
5a00de9

@bcmills bcmills added the NeedsFix label Nov 19, 2018

@bcmills bcmills added this to the Go1.13 milestone Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment