Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
This is a workaround for a go list regression that broke go/packages but went unnoticed by because of a missing call to packages.PrintErrors, added here. Updates golang/go#28749 Change-Id: I1819a6143134a422791106ac037d3458ef864322 Reviewed-on: https://go-review.googlesource.com/c/149237 Reviewed-by: Ian Cottrell <email@example.com>
var srcfiles string // .go and non-.go srcfiles = append(srcfiles, gofiles...) srcfiles = append(srcfiles, sfiles...) srcfiles = append(srcfiles, cfiles...) srcfiles = append(srcfiles, cxxfiles...) b.cacheSrcFiles(a, srcfiles)
We should make cmd/go filter out non-Go files.
There's a comment in the go/packages source code, where it manually skips
If we don't fix this for 1.12, we'll have to keep the workaround in go/packages for a long time. And expand it to cover
I'll send a CL to expand the go/packages workaround, but I think it might be good to know how risky it is to fix this yet in cmd/go.