Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: replace with go/analysis driver #28756

Closed
alandonovan opened this issue Nov 13, 2018 · 3 comments
Closed

cmd/vet: replace with go/analysis driver #28756

alandonovan opened this issue Nov 13, 2018 · 3 comments
Assignees
Milestone

Comments

@alandonovan
Copy link
Contributor

@alandonovan alandonovan commented Nov 13, 2018

This is a tracking issue for the task of migrating cmd/vet to the new go/analysis API.

  • bring the vet fork up to date w.r.t. the few recent changes in cmd/vet
  • ensure that cmd/vet command-line documentation is accurate
  • update cmd/vendor, adding a script for this and future updates.
  • change cmd/vet/all to use "go vet" instead of "go tool vet",
    and measure any performance impact on the builders.
    This requires investigating all deviations in cmd/vet/all diagnostics.
    The main issue here is github.com//issues/27665.
    Most of the other differences result from "go vet" being more precise than "go tool vet".
  • replace cmd/vet with a copy of vet-lite's short main.go file.

At that point, "go vet" will use the new driver.

@alandonovan alandonovan self-assigned this Nov 13, 2018
@alandonovan

This comment has been minimized.

Copy link
Contributor Author

@alandonovan alandonovan commented Nov 14, 2018

Update:

@bcmills bcmills added the NeedsFix label Nov 19, 2018
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Nov 19, 2018

@alandonovan, is this landing for 1.12?

@bcmills bcmills added this to the Go1.12 milestone Nov 19, 2018
@alandonovan

This comment has been minimized.

Copy link
Contributor Author

@alandonovan alandonovan commented Nov 19, 2018

Yes, this issue is now resolved.

@golang golang locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.