Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: rename GODEBUGCPU=foo=bar to GODEBUG=cpu.foo=bar #28757

Closed
rsc opened this issue Nov 13, 2018 · 2 comments

Comments

Assignees

@martisch martisch

Labels
release-blocker
Projects
None yet
Milestone
  Go1.12
3 participants
@rsc @martisch @gopherbot
@rsc
Copy link
Contributor

commented Nov 13, 2018

We have successfully managed to use a single GODEBUG environment variable for runtime, net, and net/http. It doesn't really make sense to have the runtime add a second. It's not that special. Instead we should add the functionality currently in GODEBUGCPU to GODEBUG, with longer key names.

Go 1.12 intends to document the new cpu controls (see #27218), so we should change this for Go 1.12. (It has never been documented before.)

/cc @martisch @aclements

@rsc rsc added this to the Go1.12 milestone Nov 13, 2018

@rsc rsc added the release-blocker label Nov 13, 2018

@martisch

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 13, 2018

SGTM. I will make the changes to move GODEBUGCPU functionality into GODEBUG for Go 1.12.

@martisch martisch self-assigned this Nov 13, 2018

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 14, 2018

Change https://golang.org/cl/149578 mentions this issue: internal/cpu: move GODEBUGCPU options into GODEBUG

@gopherbot gopherbot closed this in 0a40d45 Nov 14, 2018

bradfitz pushed a commit that referenced this issue Nov 21, 2018

@martisch
internal/cpu: move GODEBUGCPU options into GODEBUG 
Change internal/cpu feature configuration to use
GODEBUG=cpu.feature1=value,cpu.feature2=value...
instead of GODEBUGCPU=feature1=value,feature2=value... .

This is not a backwards compatibility breaking change
since GODEBUGCPU was introduced in go1.11 as an
undocumented compiler experiment.

Fixes #28757

Change-Id: Ib21b3fed2334baeeb061a722ab1eb513d1137e87
Reviewed-on: https://go-review.googlesource.com/c/149578
Run-TryBot: Martin Möhrmann <martisch@uos.de>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2de5390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.