Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
runtime: rename GODEBUGCPU=foo=bar to GODEBUG=cpu.foo=bar #28757
We have successfully managed to use a single GODEBUG environment variable for runtime, net, and net/http. It doesn't really make sense to have the runtime add a second. It's not that special. Instead we should add the functionality currently in GODEBUGCPU to GODEBUG, with longer key names.
Go 1.12 intends to document the new cpu controls (see #27218), so we should change this for Go 1.12. (It has never been documented before.)
Change internal/cpu feature configuration to use GODEBUG=cpu.feature1=value,cpu.feature2=value... instead of GODEBUGCPU=feature1=value,feature2=value... . This is not a backwards compatibility breaking change since GODEBUGCPU was introduced in go1.11 as an undocumented compiler experiment. Fixes #28757 Change-Id: Ib21b3fed2334baeeb061a722ab1eb513d1137e87 Reviewed-on: https://go-review.googlesource.com/c/149578 Run-TryBot: Martin Möhrmann <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Brad Fitzpatrick <email@example.com>