Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upruntime: rename GODEBUGCPU=foo=bar to GODEBUG=cpu.foo=bar #28757
Comments
This comment has been minimized.
This comment has been minimized.
|
SGTM. I will make the changes to move GODEBUGCPU functionality into GODEBUG for Go 1.12. |
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/149578 mentions this issue: |
bradfitz
pushed a commit
that referenced
this issue
Nov 21, 2018
Change internal/cpu feature configuration to use GODEBUG=cpu.feature1=value,cpu.feature2=value... instead of GODEBUGCPU=feature1=value,feature2=value... . This is not a backwards compatibility breaking change since GODEBUGCPU was introduced in go1.11 as an undocumented compiler experiment. Fixes #28757 Change-Id: Ib21b3fed2334baeeb061a722ab1eb513d1137e87 Reviewed-on: https://go-review.googlesource.com/c/149578 Run-TryBot: Martin Möhrmann <martisch@uos.de> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have successfully managed to use a single GODEBUG environment variable for runtime, net, and net/http. It doesn't really make sense to have the runtime add a second. It's not that special. Instead we should add the functionality currently in GODEBUGCPU to GODEBUG, with longer key names.
Go 1.12 intends to document the new cpu controls (see #27218), so we should change this for Go 1.12. (It has never been documented before.)
/cc @martisch @aclements