cmd/vet: incorrect error on a MarshalXML method #28792
Closed
Comments
A CL of mine touching this code was merged yesterday, so that's probably the cause. Will look into it in a bit. |
@mvdan thanks your reply, waiting. |
Change https://golang.org/cl/149977 mentions this issue: |
hi @mvdan still have the below error info:
|
This is because vet now lives in the tools repository, and is vendored in the main repository. We need to update that vendored copy. |
Change https://golang.org/cl/150161 mentions this issue: |
@mvdan got it, thanks! |
gopherbot
pushed a commit
that referenced
this issue
Nov 19, 2018
Mainly to pull the fix for the regression in #28792. Change-Id: If71ae783fd9a9e3935186b49fdf501ba098235a2 Reviewed-on: https://go-review.googlesource.com/c/150161 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
bradfitz
pushed a commit
that referenced
this issue
Nov 21, 2018
Mainly to pull the fix for the regression in #28792. Change-Id: If71ae783fd9a9e3935186b49fdf501ba098235a2 Reviewed-on: https://go-review.googlesource.com/c/150161 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
No, only go master branch.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
My code:
What did you expect to see?
correctly run on go master.
What did you see instead?
The text was updated successfully, but these errors were encountered: