/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: fatal error: out of memory on reslice with negative index [1.11 backport] #28799

Closed
gopherbot opened this Issue Nov 14, 2018 · 4 comments

Comments

Assignees

@dr2chase dr2chase

Labels
CherryPickApproved
Projects
None yet
Milestone
  Go1.11.4
5 participants
@gopherbot @dr2chase @mark-rushakoff @bradfitz @dmitshur
@gopherbot

gopherbot commented Nov 14, 2018

@randall77 requested issue #28797 to be considered for backport to the next 1.11 minor release.

@gopherbot, please open a backport issue for 1.11.

@gopherbot gopherbot added the CherryPickCandidate label Nov 14, 2018

@gopherbot gopherbot referenced this issue Nov 14, 2018

Closed

cmd/compile: fatal error: out of memory on reslice with negative index #28797

@gopherbot gopherbot added this to the Go1.11.3 milestone Nov 14, 2018

@bradfitz bradfitz added the CherryPickApproved label Nov 14, 2018

@gopherbot gopherbot removed the CherryPickCandidate label Nov 14, 2018

@randall77 randall77 assigned dr2chase Dec 11, 2018

@dr2chase

This comment has been minimized.

Sign in to view
Contributor

dr2chase commented Dec 11, 2018

What steps do I take to accomplish a backport to 1.11?
Last time I tried to do one, I did it wrong.
@mark-rushakoff

This comment has been minimized.

Sign in to view
Contributor

mark-rushakoff commented Dec 11, 2018

There's a wiki entry that may be helpful: https://github.com/golang/go/wiki/MinorReleases#making-cherry-pick-cls
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Dec 11, 2018

Change https://golang.org/cl/153638 mentions this issue: [release-branch.go1.11] cmd/compile: check for negative upper bound to IsSliceInBounds

@dmitshur dmitshur modified the milestones: Go1.11.3, Go1.11.4 Dec 13, 2018

@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Dec 14, 2018

Closed by merging bdc7d5677edd1dab21cdaa1f6498e0c2a6c9d7bf to release-branch.go1.11.

@gopherbot gopherbot closed this Dec 14, 2018

gopherbot pushed a commit that referenced this issue Dec 14, 2018

@dr2chase @FiloSottile
[release-branch.go1.11] cmd/compile: check for negative upper bound t… 
…o IsSliceInBounds

IsSliceInBounds(x, y) asserts that y is not negative, but
there were cases where this is not true.  Change code
generation to ensure that this is true when it's not obviously
true.  Prove phase cleans a few of these out.

With this change the compiler text section is 0.06% larger,
that is, not very much.  Benchmarking still TBD, may need
to wait for access to a benchmarking box (next week).

Also corrected run.go to handle '?' in -update_errors output.

Fixes #28799.

Change-Id: Ia8af90bc50a91ae6e934ef973def8d3f398fac7b
Reviewed-on: https://go-review.googlesource.com/c/152477
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit ea6259d)
Reviewed-on: https://go-review.googlesource.com/c/153638
bdc7d56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment