Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: isDomainName should be exported #2880

Closed
patrickmn opened this issue Feb 4, 2012 · 9 comments

Comments

Projects
None yet
4 participants
@patrickmn
Copy link

commented Feb 4, 2012

It is perfectly reasonable to want to validate a domain name outside the API currently
exposed by net, and this validation is not trivial. Exporting isDomainName, however, is.
@patrickmn

This comment has been minimized.

Copy link
Author

commented Feb 4, 2012

Comment 1:

CL: http://golang.org/cl/5631048/
Also added additional test cases, for FQDN and illegal .- / -.
@dsymonds

This comment has been minimized.

Copy link
Member

commented Feb 6, 2012

Comment 2:

Labels changed: added priority-later, packagechange, removed priority-triage.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2012

Comment 4:

Status changed to Accepted.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2013

Comment 5:

[The time for maybe has passed.]
@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2013

Comment 6:

I am not really sure we want to export this.

Labels changed: added go1.2maybe.

Status changed to Thinking.

@patrickmn

This comment has been minimized.

Copy link
Author

commented Jul 30, 2013

Comment 7:

FWIW, I probably wouldn't file this ticket today
@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2013

Comment 8:

Status changed to Retracted.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2013

Comment 9:

Labels changed: added feature.

@gopherbot

This comment has been minimized.

Copy link

commented Aug 23, 2014

Comment 10 by amgadhs:

I'm curious to know, why is exporting this function a big deal? It could be used by
every program that takes a domain name as input.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015

@rsc rsc removed the go1.2maybe label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.