New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

Open
ALTree opened this Issue Nov 18, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@ALTree
Member

ALTree commented Nov 18, 2018

$ gotip version
go version devel +fe562cebf1 Sun Nov 18 16:13:13 2018 +0000 linux/amd64

To reproduce:

$ cd src/cmd/go/internal/modfetch

$ gotip test -run=TestCodeRepo
--- FAIL: TestCodeRepo (58.16s)
    --- FAIL: TestCodeRepo/gopkg.in_yaml.v2/v2 (3.32s)
        coderepo_test.go:368: info.Version = "v2.2.2-0.20181115110504-51d6538a90f8", want "v2.2.1"
        coderepo_test.go:371: info.Name = "51d6538a90f86fe93ac480b35f37b2be17fef232", want "5420a8b6744d3b0345ab293f6fcba19c978f1183"
        coderepo_test.go:374: info.Short = "51d6538a90f8", want "5420a8b6744d"
        coderepo_test.go:377: info.Time = 2018-11-15 11:05:04 +0000 UTC, want 2018-03-28 19:50:20 +0000 UTC
FAIL
exit status 1
FAIL	cmd/go/internal/modfetch	60.812s

Spotted on the longtest builder.

@ALTree ALTree added this to the Go1.12 milestone Nov 18, 2018

@josharian

This comment has been minimized.

Contributor

josharian commented Nov 18, 2018

Looks like what happened is that github.com/go-yaml/yaml added a new comment to the v2 branch: https://github.com/go-yaml/yaml/commits/v2. (Observe that previous tip was
go-yaml/yaml@5420a8b, and that new tip is
go-yaml/yaml@51d6538, which correspond to the want/have commits in the test failure.)

cc @bcmills

@andybons

This comment has been minimized.

Member

andybons commented Nov 26, 2018

Why are we running tests against repos that are active and not controlled by us? Seems that we should be hitting repos that we control and are pre-baked.

@bradfitz

@andybons andybons changed the title from cmd/go: internal/modfetch TestCodeRepo failure to cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes Nov 26, 2018

@andybons

This comment has been minimized.

Member

andybons commented Nov 26, 2018

Adding @rsc since he wrote the original code.

@dmitshur

This comment has been minimized.

Member

dmitshur commented Nov 26, 2018

Related issue #27692. It's another instance of the cmd/go tests relying on an external live repository.

@gopherbot

This comment has been minimized.

gopherbot commented Dec 10, 2018

Change https://golang.org/cl/153460 mentions this issue: cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2 v2.2.2

gopherbot pushed a commit that referenced this issue Dec 10, 2018

cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2 v2…
….2.2

I think we ought to make these tests hermetic, but in the meantime we
should at least make them pass.

Fixes #27692
Updates #28856

Change-Id: Ia78fa60e998dea3c871f640ffa2ece67b054f866
Reviewed-on: https://go-review.googlesource.com/c/153460
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment