Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

Open
ALTree opened this issue Nov 18, 2018 · 28 comments
Open

cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

ALTree opened this issue Nov 18, 2018 · 28 comments
Assignees
Milestone

Comments

@ALTree
Copy link
Member

@ALTree ALTree commented Nov 18, 2018

$ gotip version
go version devel +fe562cebf1 Sun Nov 18 16:13:13 2018 +0000 linux/amd64

To reproduce:

$ cd src/cmd/go/internal/modfetch

$ gotip test -run=TestCodeRepo
--- FAIL: TestCodeRepo (58.16s)
    --- FAIL: TestCodeRepo/gopkg.in_yaml.v2/v2 (3.32s)
        coderepo_test.go:368: info.Version = "v2.2.2-0.20181115110504-51d6538a90f8", want "v2.2.1"
        coderepo_test.go:371: info.Name = "51d6538a90f86fe93ac480b35f37b2be17fef232", want "5420a8b6744d3b0345ab293f6fcba19c978f1183"
        coderepo_test.go:374: info.Short = "51d6538a90f8", want "5420a8b6744d"
        coderepo_test.go:377: info.Time = 2018-11-15 11:05:04 +0000 UTC, want 2018-03-28 19:50:20 +0000 UTC
FAIL
exit status 1
FAIL	cmd/go/internal/modfetch	60.812s

Spotted on the longtest builder.

@ALTree ALTree added this to the Go1.12 milestone Nov 18, 2018
@josharian
Copy link
Contributor

@josharian josharian commented Nov 18, 2018

Looks like what happened is that github.com/go-yaml/yaml added a new comment to the v2 branch: https://github.com/go-yaml/yaml/commits/v2. (Observe that previous tip was
go-yaml/yaml@5420a8b, and that new tip is
go-yaml/yaml@51d6538, which correspond to the want/have commits in the test failure.)

cc @bcmills

@andybons
Copy link
Member

@andybons andybons commented Nov 26, 2018

Why are we running tests against repos that are active and not controlled by us? Seems that we should be hitting repos that we control and are pre-baked.

@bradfitz

@andybons andybons changed the title cmd/go: internal/modfetch TestCodeRepo failure cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes Nov 26, 2018
@andybons
Copy link
Member

@andybons andybons commented Nov 26, 2018

Adding @rsc since he wrote the original code.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 26, 2018

Related issue #27692. It's another instance of the cmd/go tests relying on an external live repository.

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 10, 2018

Change https://golang.org/cl/153460 mentions this issue: cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2 v2.2.2

gopherbot pushed a commit that referenced this issue Dec 10, 2018
….2.2

I think we ought to make these tests hermetic, but in the meantime we
should at least make them pass.

Fixes #27692
Updates #28856

Change-Id: Ia78fa60e998dea3c871f640ffa2ece67b054f866
Reviewed-on: https://go-review.googlesource.com/c/153460
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 6, 2019

@bcmills I think CL 153460 has resolved this issue fully, has it not? If not, what's left here?

@bcmills bcmills removed the Soon label Mar 7, 2019
@bcmills
Copy link
Member

@bcmills bcmills commented Mar 7, 2019

@dmitshur, ideally we should make the tests hermetic (for example, by running or emulating a local Git server and substituting paths to point to it).

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 21, 2019

Change https://golang.org/cl/168561 mentions this issue: cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2

@ALTree
Copy link
Member Author

@ALTree ALTree commented Mar 21, 2019

Happened again, I sent the patch above to align the expected data for now, waiting for the test to become independent from external repositories.

gopherbot pushed a commit that referenced this issue Mar 21, 2019
New release, it broke again the longtest builder. Align the expected
data with the current release.

Making these tests independent of external repositories is #28856.

This fixes the longtest builder.

Updates #28856

Change-Id: I32d2f3325af828d26ab417a5e986e3aeefa1a897
Reviewed-on: https://go-review.googlesource.com/c/go/+/168561
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 1, 2019

Change https://golang.org/cl/198117 mentions this issue: cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2

@andybons
Copy link
Member

@andybons andybons commented Oct 1, 2019

Happened again.

--- FAIL: TestCodeRepo (9.55s)
    --- FAIL: TestCodeRepo/parallel (0.00s)
        --- FAIL: TestCodeRepo/parallel/gopkg.in_yaml.v2/v2 (3.62s)
            coderepo_test.go:443: info.Version = "v2.2.3", want "v2.2.3-0.20190319135612-7b8349ac747c"
            coderepo_test.go:446: info.Name = "bb4e33bf68bf89cad44d386192cbed201f35b241", want "7b8349ac747c6a24702b762d2c4fd9266cf4f1d6"
            coderepo_test.go:449: info.Short = "bb4e33bf68bf", want "7b8349ac747c"
            coderepo_test.go:452: info.Time = 2019-09-30 19:09:21 +0000 UTC, want 2019-03-19 13:56:12 +0000 UTC

From https://build.golang.org/log/b73d1e539a95bac69fec321f90c305f4b69944fe

@dmitshur dmitshur assigned dmitshur and unassigned dmitshur Oct 1, 2019
gopherbot pushed a commit that referenced this issue Oct 3, 2019
… for gopkg.in/yaml.v2 again

Update the expected data to fix the longtest builder.

Updates #28856

Change-Id: I7fb6ee72e8469d974561b4b4057f40142f5b3654
Reviewed-on: https://go-review.googlesource.com/c/go/+/198557
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 64785bf)
Reviewed-on: https://go-review.googlesource.com/c/go/+/198700
Run-TryBot: Bryan C. Mills <bcmills@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 9, 2019

Change https://golang.org/cl/200038 mentions this issue: [release-branch.go1.12] cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2 again

gopherbot pushed a commit that referenced this issue Oct 9, 2019
… for gopkg.in/yaml.v2 again

Update the expected data to fix the longtest builder.

Updates #28856

Change-Id: I7fb6ee72e8469d974561b4b4057f40142f5b3654
Reviewed-on: https://go-review.googlesource.com/c/go/+/198557
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 64785bf)
Reviewed-on: https://go-review.googlesource.com/c/go/+/198700
Run-TryBot: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 17a492f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/200038
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@ALTree ALTree added the Soon label Nov 5, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 5, 2019

Change https://golang.org/cl/205437 mentions this issue: cmd/go/internal/modfetch: remove non-hermetic test

gopherbot pushed a commit that referenced this issue Nov 5, 2019
The test for gopkg.in/yaml.v2@v2 assumes that there are
no future upstream releases. That assumption empirically
does not hold. Backporting fixes to this test is annoying,
and other gopkg.in cases are already reasonably covered,
so remove the problematic test.

Updates #28856

Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17
Reviewed-on: https://go-review.googlesource.com/c/go/+/205437
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 5, 2019

Change https://golang.org/cl/205439 mentions this issue: [release-branch.go1.12] cmd/go/internal/modfetch: remove non-hermetic test

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 5, 2019

Change https://golang.org/cl/205438 mentions this issue: [release-branch.go1.13] cmd/go/internal/modfetch: remove non-hermetic test

gopherbot pushed a commit that referenced this issue Dec 11, 2019
… test

The test for gopkg.in/yaml.v2@v2 assumes that there are
no future upstream releases. That assumption empirically
does not hold. Backporting fixes to this test is annoying,
and other gopkg.in cases are already reasonably covered,
so remove the problematic test.

Updates #28856

Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17
Reviewed-on: https://go-review.googlesource.com/c/go/+/205437
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit f0390ff)
Reviewed-on: https://go-review.googlesource.com/c/go/+/205438
Reviewed-by: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Dec 11, 2019
… test

The test for gopkg.in/yaml.v2@v2 assumes that there are
no future upstream releases. That assumption empirically
does not hold. Backporting fixes to this test is annoying,
and other gopkg.in cases are already reasonably covered,
so remove the problematic test.

Updates #28856

Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17
Reviewed-on: https://go-review.googlesource.com/c/go/+/205437
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit f0390ff)
Reviewed-on: https://go-review.googlesource.com/c/go/+/205439
Reviewed-by: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 25, 2020

This is neither a regression, serious bug, nor an outage, so removing Soon. It should be fixed, but that label is meant for things that are done in the order of days.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 28, 2020

There were some additional cmd/go tests failing on the longtest builder because rsc.io, swtch.com, and insecure.go-get-issue-15410.appspot.com domains were not serving Go packages (see #40452).

Specifically (from https://storage.googleapis.com/go-build-log/3c347861/linux-amd64-longtest_bb29e807.log, https://storage.googleapis.com/go-build-log/2229151e/linux-386-longtest_dca9ed82.log, and https://storage.googleapis.com/go-build-log/0fcc0a58/linux-amd64-longtest_642c58db.log):


--- FAIL: TestGoGetCustomDomainWildcard (0.24s)
    go_test.go:2628: running testgo [get -u rsc.io/pdf/...]
    go_test.go:2628: standard error:
    go_test.go:2628: package rsc.io/pdf/...: unrecognized import path "rsc.io/pdf": reading https://rsc.io/pdf?go-get=1: 503 Service Unavailable
        
    go_test.go:2628: go [get -u rsc.io/pdf/...] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
--- FAIL: TestGoGetDotSlashDownload (0.22s)
    go_test.go:2714: running testgo [get ./pprof_mac_fix]
    go_test.go:2714: standard error:
    go_test.go:2714: unrecognized import path "rsc.io/pprof_mac_fix": reading https://rsc.io/pprof_mac_fix?go-get=1: 503 Service Unavailable
        
    go_test.go:2714: go [get ./pprof_mac_fix] failed unexpectedly in /workdir/tmp/cmd-go-test-062451185/gotest700832841/src/rsc.io: exit status 1
    panic.go:617: ended in /workdir/tmp/cmd-go-test-062451185/gotest700832841/src/rsc.io
--- FAIL: TestGoGetInsecure (1.38s)
    --- FAIL: TestGoGetInsecure/gopath (0.11s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
    --- FAIL: TestGoGetInsecure/modules (1.26s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/tmp/cmd-go-test-062451185/gotest738708835: exit status 1
        panic.go:617: ended in /workdir/tmp/cmd-go-test-062451185/gotest738708835
--- FAIL: TestGoGetInsecureCustomDomain (0.09s)
    go_test.go:2983: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2983: standard error:
    go_test.go:2983: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
        
    go_test.go:2983: testgo failed as expected: exit status 1
    go_test.go:2984: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2984: standard error:
    go_test.go:2984: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
        
    go_test.go:2984: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
go test proxy running at GOPROXY=http://127.0.0.1:45253/mod
go proxy: no archive rsc.io v1.5.1: file does not exist
go proxy: no archive example.com/newcycle v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.4.0: file does not exist
go proxy: no archive rsc.io v1.5.2: file does not exist
go proxy: no archive rsc.io v1.1.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive golang.org v0.1.0: file does not exist
go proxy: no archive golang.org v0.3.0: file does not exist
go proxy: no archive golang.org/x v0.1.0: file does not exist
go proxy: no archive golang.org/x v0.3.0: file does not exist
go proxy: no archive example.com v0.1.0: file does not exist
go proxy: no archive rsc.io v1.5.2: file does not exist
--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_init_dep (0.24s)
        script_test.go:193: 
            # modconv uses git directly to examine what old 'go get' would (0.001s)
            # go build should populate go.mod from Gopkg.lock (0.229s)
            > cp go.mod1 go.mod
            > go build
            [stderr]
            go: copying requirements from Gopkg.lock
            go: converting Gopkg.lock: stat rsc.io/sampler@v1.0.0: unrecognized import path "rsc.io/sampler": reading https://rsc.io/sampler?go-get=1: 503 Service Unavailable
            > stderr 'copying requirements from Gopkg.lock'
            > go list -m all
            [stdout]
            x
            > ! stderr 'copying requirements from Gopkg.lock'
            > stdout 'rsc.io/sampler v1.0.0'
            FAIL: testdata/script/mod_init_dep.txt:13: no match for `(?m)rsc.io/sampler v1.0.0` found in stdout
            
    --- FAIL: TestScript/mod_gonoproxy (0.78s)
        script_test.go:193: 
            # disagree with sumdb fails (0.028s)
            # but GONOSUMDB bypasses sumdb, for rsc.io/quote, rsc.io/sampler, golang.org/x/text (0.560s)
            # and GONOPROXY bypasses proxy (0.169s)
            > [!net] skip
            > [!exec:git] skip
            > env GOPRIVATE=none
            > env GONOPROXY='*/fortune'
            > ! go get rsc.io/fortune # does not exist in real world, only on test proxy
            [stderr]
            go get rsc.io/fortune: unrecognized import path "rsc.io/fortune": reading https://rsc.io/fortune?go-get=1: 503 Service Unavailable
            [exit status 1]
            > stderr 'git ls-remote'
            FAIL: testdata/script/mod_gonoproxy.txt:27: no match for `(?m)git ls-remote` found in stderr
            
    --- FAIL: TestScript/mod_download_hash (0.31s)
        script_test.go:193: 
            # Testing mod download with non semantic versions; turn off proxy. (0.307s)
            > [!net] skip
            > [!exec:git] skip
            > env GOPROXY=direct
            > env GOSUMDB=off
            > go mod download rsc.io/quote@a91498bed0a73d4bb9c1fb2597925f7883bc40a7
            [stderr]
            rsc.io/quote@a91498bed0a73d4bb9c1fb2597925f7883bc40a7: unrecognized import path "rsc.io/quote": reading https://rsc.io/quote?go-get=1: 503 Service Unavailable
            [exit status 1]
            FAIL: testdata/script/mod_download_hash.txt:9: unexpected command failure
            
    --- FAIL: TestScript/mod_sumdb_golang (0.27s)
        script_test.go:193: 
            # Test default GOPROXY and GOSUMDB (0.083s)
            # download direct from github (0.190s)
            > [!net] skip
            > [!exec:git] skip
            > env GOSUMDB=sum.golang.org
            > env GOPROXY=direct
            > go get -d rsc.io/quote@v1.5.2
            [stderr]
            go get rsc.io/quote@v1.5.2: unrecognized import path "rsc.io/quote": reading https://rsc.io/quote?go-get=1: 503 Service Unavailable
            [exit status 1]
            FAIL: testdata/script/mod_sumdb_golang.txt:17: unexpected command failure
            
    --- FAIL: TestScript/gopath_moved_repo (0.87s)
        script_test.go:193: 
            # Test that 'go get -u' reports packages whose VCS configurations do not
            # match their import paths. (0.000s)
            # We need to execute a custom Go program to break the config files.
            #
            # git will ask for a username and password when we run 'go get -d -f -u',
            # so we also need to set GIT_ASKPASS. Conveniently, a single binary can
            # perform both tasks! (0.674s)
            # Test that 'go get -u' reports moved git packages. (0.191s)
            > [exec:git] go get -d rsc.io/pdf
            [stderr]
            unrecognized import path "rsc.io/pdf": reading https://rsc.io/pdf?go-get=1: 503 Service Unavailable
            [exit status 1]
            FAIL: testdata/script/gopath_moved_repo.txt:21: unexpected command failure
            
--- FAIL: TestIssue11457 (0.20s)
    go_test.go:1087: running testgo [get -d -u rsc.io/go-get-issue-11457]
    go_test.go:1087: standard error:
    go_test.go:1087: unrecognized import path "rsc.io/go-get-issue-11457": reading https://rsc.io/go-get-issue-11457?go-get=1: 503 Service Unavailable
        
    go_test.go:1087: go [get -d -u rsc.io/go-get-issue-11457] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
--- FAIL: TestIssue16471 (1.31s)
    go_test.go:1071: git standard error:
    go_test.go:1071: Cloning into 'go-get-issue-10952'...
        
    go_test.go:1072: running testgo [get -u rsc.io/go-get-issue-10952]
    go_test.go:1072: testgo succeeded unexpectedly
FAIL
FAIL	cmd/go	132.219s
FAIL
--- FAIL: TestCodeRepo (11.97s)
    --- FAIL: TestCodeRepo/parallel (0.00s)
        --- FAIL: TestCodeRepo/parallel/swtch.com_testmod/v1.0.0 (0.14s)
            coderepo_test.go:451: Lookup("swtch.com/testmod"): unrecognized import path "swtch.com/testmod": reading https://swtch.com/testmod?go-get=1: 503 Service Unavailable
--- FAIL: TestCodeRepoVersions (1.58s)
    --- FAIL: TestCodeRepoVersions/parallel (0.00s)
        --- FAIL: TestCodeRepoVersions/parallel/swtch.com_testmod (0.00s)
            coderepo_test.go:690: Lookup("swtch.com/testmod"): unrecognized import path "swtch.com/testmod": reading https://swtch.com/testmod?go-get=1: 503 Service Unavailable
--- FAIL: TestLatest (0.47s)
    --- FAIL: TestLatest/parallel (0.00s)
        --- FAIL: TestLatest/parallel/swtch.com_testmod (0.00s)
            coderepo_test.go:768: Lookup("swtch.com/testmod"): unrecognized import path "swtch.com/testmod": reading https://swtch.com/testmod?go-get=1: 503 Service Unavailable
FAIL
FAIL	cmd/go/internal/modfetch	14.044s
--- FAIL: TestGoGetInsecure (1.44s)
    --- FAIL: TestGoGetInsecure/gopath (0.13s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
    --- FAIL: TestGoGetInsecure/modules (1.30s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/tmp/cmd-go-test-772897562/gotest647673300: exit status 1
        panic.go:617: ended in /workdir/tmp/cmd-go-test-772897562/gotest647673300
--- FAIL: TestGoGetInsecureCustomDomain (0.10s)
    go_test.go:2983: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2983: standard error:
    go_test.go:2983: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
        
    go_test.go:2983: testgo failed as expected: exit status 1
    go_test.go:2984: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2984: standard error:
    go_test.go:2984: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
        
    go_test.go:2984: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1

@bcmills @matloob @jayconrod Is it in scope for this issue to make those tests not fail if rsc.io, or swtch.com, or insecure.go-get-issue-15410.appspot.com are not available (potentially by moving them to vcs-test.golang.org and insecure.vcs-test.golang.org or so), or is it better to make these separate issues?

@bcmills
Copy link
Member

@bcmills bcmills commented Jul 31, 2020

@dmitshur, this issue is specifically about TestCodeRepo, so separate issues would probably be good. Ideally, we should resolve these by starting up a test-local server rather than merely moving the tests to vcs-test.golang.org, but that's a lot of work...

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 31, 2020

Sounds good. Factored it out into a standalone issue #40519.

@ALTree
Copy link
Member Author

@ALTree ALTree commented Oct 28, 2020

longtest builders broken again:
https://build.golang.org/log/f95a05162e528c34983f8d4604d76a6f427f86e6

--- FAIL: TestCodeRepoVersions (1.80s)
    --- FAIL: TestCodeRepoVersions/parallel (0.00s)
        --- FAIL: TestCodeRepoVersions/parallel/gopkg.in_russross_blackfriday.v2 (1.80s)
            coderepo_test.go:684: Versions(""):
                have [v2.0.0 v2.0.1 v2.1.0-pre.1]
                want [v2.0.0 v2.0.1]
FAIL
FAIL	cmd/go/internal/modfetch	17.284s
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 28, 2020

Change https://golang.org/cl/265819 mentions this issue: cmd/go/internal/modfetch: update expected tags for TestCodeRepoVersions

gopherbot pushed a commit that referenced this issue Oct 28, 2020
Updates #28856

Change-Id: I89c564cefd7c5777904bc00c74617dab693373bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/265819
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 28, 2020

Change https://golang.org/cl/265917 mentions this issue: cmd/go/internal/modfetch: drop gopkg.in/russross/blackfriday.v2 from TestCodeRepoVersions

gopherbot pushed a commit that referenced this issue Oct 28, 2020
…TestCodeRepoVersions

Follow-up for CL 265819.

Given the -pre tag added recently, a new stable version is likely
tagged soon. This would break TestCodeRepoVersions on the longtest
builders again. Since the other test cases in codeRepoVersionsTests
already provide enough coverage, drop gopkg.in/russross/blackfriday.v2
to avoid breaking TestCodeRepoVersions once the release happens.

Updates #28856

Change-Id: If86a637b5e47f59faf9048fc1cbbae6e8f1dcc53
Reviewed-on: https://go-review.googlesource.com/c/go/+/265917
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 28, 2020

Change https://golang.org/cl/266178 mentions this issue: [release-branch.go1.15] cmd/go/internal/modfetch: drop gopkg.in/russross/blackfriday.v2 from TestCodeRepoVersions

gopherbot pushed a commit that referenced this issue Oct 29, 2020
…oss/blackfriday.v2 from TestCodeRepoVersions

Follow-up for CL 265819.

Given the -pre tag added recently, a new stable version is likely
tagged soon. This would break TestCodeRepoVersions on the longtest
builders again. Since the other test cases in codeRepoVersionsTests
already provide enough coverage, drop gopkg.in/russross/blackfriday.v2
to avoid breaking TestCodeRepoVersions once the release happens.

Updates #28856

Change-Id: If86a637b5e47f59faf9048fc1cbbae6e8f1dcc53
Reviewed-on: https://go-review.googlesource.com/c/go/+/265917
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 421d4e7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/266178
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 29, 2020

Change https://golang.org/cl/266302 mentions this issue: [release-branch.go1.14] cmd/go/internal/modfetch: drop gopkg.in/russross/blackfriday.v2 from TestCodeRepoVersions

gopherbot pushed a commit that referenced this issue Oct 30, 2020
…oss/blackfriday.v2 from TestCodeRepoVersions

Follow-up for CL 265819.

Given the -pre tag added recently, a new stable version is likely
tagged soon. This would break TestCodeRepoVersions on the longtest
builders again. Since the other test cases in codeRepoVersionsTests
already provide enough coverage, drop gopkg.in/russross/blackfriday.v2
to avoid breaking TestCodeRepoVersions once the release happens.

Updates #28856

Change-Id: If86a637b5e47f59faf9048fc1cbbae6e8f1dcc53
Reviewed-on: https://go-review.googlesource.com/c/go/+/265917
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 421d4e7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/266178
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
(cherry picked from commit 8687f6d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/266302
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants